From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA199C28CC5 for ; Thu, 6 Jun 2019 01:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E15E2083E for ; Thu, 6 Jun 2019 01:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559783664; bh=g1UL1wAjgceXSzuwYTKaFWPQnj/kbq2Ld7r6iHfv+aI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zLeLoqh9P0ZFqoSuVed+Ou766wX5cbEuRxT723L4dxVlEY9vi3h2NxNPnsd5dir1U igFgT7flMdNfcfyZ5+RbKprkh2GO0LEWPozPYX+8sKAxiMTerFez/IsrFeatyQbMdX UXc3On5o5bRdXsCP45MIzOiktF0Pys+FdZ8AexJ8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbfFFBOY (ORCPT ); Wed, 5 Jun 2019 21:14:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:34154 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726543AbfFFBOY (ORCPT ); Wed, 5 Jun 2019 21:14:24 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3422E2070B; Thu, 6 Jun 2019 01:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559783663; bh=g1UL1wAjgceXSzuwYTKaFWPQnj/kbq2Ld7r6iHfv+aI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V0JKCU0YiOCLo6PPXaLci0hC4lCxVPOub+PPKheilYMhNe6jsQ31aLBND0+fYWeAP YRhlBCfJDc41WVQ+07+jBW8mp1Uk9oMZ9eC//ulM6GMgVl8VKf8dc9Q0BvU1ch5e7A kkDeEYej4ekqEr3lUlTEh4dEhHyNOQKSekLq+yKE= Date: Wed, 5 Jun 2019 21:14:22 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: Phil Elwell , stable@vger.kernel.org Subject: Re: Dynamic overlay failure in 4.19 & 4.20 Message-ID: <20190606011422.GG29739@sasha-vm> References: <45e99a24-efb9-5473-2e57-14411537dc9f@raspberrypi.org> <2da582d1-11eb-3680-33f2-3a5c139613a8@raspberrypi.org> <20190605175059.GA29747@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190605175059.GA29747@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jun 05, 2019 at 07:50:59PM +0200, Greg Kroah-Hartman wrote: >On Wed, Jun 05, 2019 at 01:02:18PM +0100, Phil Elwell wrote: >> Hi, >> >> I think patch f96278810150 ("of: overlay: set node fields from >> properties when add new overlay node") should be back-ported to 4.19, >> for the reasons outlined below (briefly: without it, overlay fragments >> that define phandles will appear to merged successfully, but they do >> so without those phandles, causing any references to them to break). > >That patch does not properly apply to the 4.19.y tree. Can you provide >a working backport that I can queue up to resolve this? Greg, That patch has contextual dependencies on 6f75118800 ("of: overlay: validate overlay properties #address-cells and #size-cells"), I think it would make sense to take 6f75118800 and then f96278810150 rather than a backport. -- Thanks, Sasha