From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C8CC31E49 for ; Thu, 13 Jun 2019 16:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68D0E2173C for ; Thu, 13 Jun 2019 16:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560443425; bh=wgZYSOSAN4HOEBQQVHeUrlpqH3CZZuKEdPfnDdhlo7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mYKpFiYGTUtOOO8eBun9hgghJihx+geL5IS4kdfM+1jKefZbuRiZqotdwREIiHoYK AiQf8kXhg89m2z6IOfxjMlB624J3xvAlA7nkxjyNMQfp4CNU+Fd3w+9KHmhkFXPrns mqlZfIc/RLEu8zQMn6e8b/SEU1UpApmFD2SFZGfg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392093AbfFMQaY (ORCPT ); Thu, 13 Jun 2019 12:30:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:52634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730912AbfFMIex (ORCPT ); Thu, 13 Jun 2019 04:34:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2099206E0; Thu, 13 Jun 2019 08:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560414892; bh=wgZYSOSAN4HOEBQQVHeUrlpqH3CZZuKEdPfnDdhlo7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cc6DAzC7rD1ud2RbPeErMJQWieF6SACgMsFiyHxqdyf1pPjGR+YCRjjuxdhwTh62z b4hvqEalDVNuiLR60fv0ImxVal0YyRodeFybcL53nuJNNmGyHYxKwl13DsHB46+SRC +KSe08WMsHk8e/cdeJg/lCuj5FPp4iTrfuEk2d0Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hou Tao , OGAWA Hirofumi , Al Viro , Jan Kara , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.14 02/81] fs/fat/file.c: issue flush after the writeback of FAT Date: Thu, 13 Jun 2019 10:32:45 +0200 Message-Id: <20190613075649.252328791@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190613075649.074682929@linuxfoundation.org> References: <20190613075649.074682929@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit bd8309de0d60838eef6fb575b0c4c7e95841cf73 ] fsync() needs to make sure the data & meta-data of file are persistent after the return of fsync(), even when a power-failure occurs later. In the case of fat-fs, the FAT belongs to the meta-data of file, so we need to issue a flush after the writeback of FAT instead before. Also bail out early when any stage of fsync fails. Link: http://lkml.kernel.org/r/20190409030158.136316-1-houtao1@huawei.com Signed-off-by: Hou Tao Acked-by: OGAWA Hirofumi Cc: Al Viro Cc: Jan Kara Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/fat/file.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/fs/fat/file.c b/fs/fat/file.c index 4724cc9ad650..62581de09bf1 100644 --- a/fs/fat/file.c +++ b/fs/fat/file.c @@ -160,12 +160,17 @@ static int fat_file_release(struct inode *inode, struct file *filp) int fat_file_fsync(struct file *filp, loff_t start, loff_t end, int datasync) { struct inode *inode = filp->f_mapping->host; - int res, err; + int err; + + err = __generic_file_fsync(filp, start, end, datasync); + if (err) + return err; - res = generic_file_fsync(filp, start, end, datasync); err = sync_mapping_buffers(MSDOS_SB(inode->i_sb)->fat_inode->i_mapping); + if (err) + return err; - return res ? res : err; + return blkdev_issue_flush(inode->i_sb->s_bdev, GFP_KERNEL, NULL); } -- 2.20.1