From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9540CC31E5C for ; Mon, 17 Jun 2019 21:34:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 602932063F for ; Mon, 17 Jun 2019 21:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560807243; bh=nuTBTUniMMIWaC+J+YSeaqG863Sn/HbEPXh0mL4IJ18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JQiXKxQ4sCOANGyjWguO3b3jnlEmBVGrzm4x+MNGaMcG0NhtrYk+k3db+Bw2VhgI+ /3cypiOtqaW9CuX09XYYcmMTIuP2P4gSz+W86dxFHe0yo+4vOvNufFqVYqxUBBsHTp gFQ5PmpRQ1TeAeyarE+EkOHp42QKWigr1RQNrDZo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729444AbfFQVd6 (ORCPT ); Mon, 17 Jun 2019 17:33:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:51582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730067AbfFQVZ1 (ORCPT ); Mon, 17 Jun 2019 17:25:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72FE2206B7; Mon, 17 Jun 2019 21:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560806726; bh=nuTBTUniMMIWaC+J+YSeaqG863Sn/HbEPXh0mL4IJ18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N01AEqlWHR/q8QqChasVyiHpS26fftsRONSavLM2iZgQFae2Z/66fu10Vgyr4m49O anmc2VAavmyqrFI9kob3WnZ37hlYJ01gwZ4aQhyC/ZohTc8FHd7PbW7UCgmxTXbuye N65NM8D0j8VmUkM4+h+AU18uoQYneO0yjgkNLx8A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dick Kennedy , James Smart , Bart Van Assche , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 37/75] scsi: lpfc: add check for loss of ndlp when sending RRQ Date: Mon, 17 Jun 2019 23:09:48 +0200 Message-Id: <20190617210754.221394073@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190617210752.799453599@linuxfoundation.org> References: <20190617210752.799453599@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit c8cb261a072c88ca1aff0e804a30db4c7606521b ] There was a missing qualification of a valid ndlp structure when calling to send an RRQ for an abort. Add the check. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Tested-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_els.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 0d214e6b8e9a..f3c6801c0b31 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -7094,7 +7094,10 @@ int lpfc_send_rrq(struct lpfc_hba *phba, struct lpfc_node_rrq *rrq) { struct lpfc_nodelist *ndlp = lpfc_findnode_did(rrq->vport, - rrq->nlp_DID); + rrq->nlp_DID); + if (!ndlp) + return 1; + if (lpfc_test_rrq_active(phba, ndlp, rrq->xritag)) return lpfc_issue_els_rrq(rrq->vport, ndlp, rrq->nlp_DID, rrq); -- 2.20.1