From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A7DC48BE3 for ; Thu, 20 Jun 2019 14:15:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C788B20679 for ; Thu, 20 Jun 2019 14:15:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="ldbWOywL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Qs6gNeok" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731950AbfFTOPy (ORCPT ); Thu, 20 Jun 2019 10:15:54 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44733 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731943AbfFTOPx (ORCPT ); Thu, 20 Jun 2019 10:15:53 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 41EE3220EB; Thu, 20 Jun 2019 10:15:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 20 Jun 2019 10:15:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=olGQayuTAXkDyp5Vn6sgCIfCq0O 50GeQrrkDfRM4POQ=; b=ldbWOywLSz/NsGj53nBBi8XrPt261ZUVEEslcJnflEW 4Zof7uouBVZl4yFgduIt0wztS4yfWxI2c/Y9CZmkFvOL92ZaYcQlCjbPrGCJSU27 PU5iPoPAaId4qqhYejYZMQE649BzOkXcU1Ouer4j+frVEaY963UbyZjgvhRhYjza 7Jsg6yoewbqdbgo8LOZ5TiIRBQXfVxRi1kGMq81SNIrcPji3OlHJuq5XzHeH/Vyt w+5N6hqjcqU8yOf8VpJ44JsAtjbZtwgGAIVr3rXvcldbSjEd8spnn73+yFVkD8Lx lXEePWwQymJQlv/8AoTMQQ0aEIB6hQnFeIzgpCcuFxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=olGQay uTAXkDyp5Vn6sgCIfCq0O50GeQrrkDfRM4POQ=; b=Qs6gNeok3Nj724ceimH1or +j7T68TdsaMG/E4QwF4yO5YRuf6ePp/fH41fTv7hiFyVIUZyh8HidI2xsa1MY8AN dBntCAyJhSV1t8YVi5FMLIkdVpcO1NEKmfal91aCVcUhhrWGWGVEtHj/QIjinhHu hBnfOrF8TQxV3/CgVpcFxH+uoiPrDFM6Ey1PcNV5yqcxoNGz2qt7ZwUqpE7/zJ9F v+X1Bj/M0mluvZsZ17Y+gQnrK0OU2Gy95Uczp682dWheL2iM+D0AKefQ6bE2U8KS 2zzLjMDGssKAbaYiWS6LRSBzCa8SZrDMRk+fA+zEISmPWYb7keo/zkSx+GuuB44w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrtdeggdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrddutd ejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 139448005A; Thu, 20 Jun 2019 10:15:50 -0400 (EDT) Date: Thu, 20 Jun 2019 16:15:49 +0200 From: Greg KH To: "Gerecke, Jason" Cc: stable@vger.kernel.org, Aaron Armstrong Skomra , Benjamin Tissoires , Jason Gerecke , Aaron Armstrong Skomra Subject: Re: [PATCH 1/3] HID: wacom: Don't set tool type until we're in range Message-ID: <20190620141549.GA9832@kroah.com> References: <15606126649212@kroah.com> <20190617215946.13423-1-jason.gerecke@wacom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190617215946.13423-1-jason.gerecke@wacom.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jun 17, 2019 at 02:59:46PM -0700, Gerecke, Jason wrote: > From: Jason Gerecke > > The serial number and tool type information that is reported by the tablet > while a pen is merely "in prox" instead of fully "in range" can be stale > and cause us to report incorrect tool information. Serial number, tool > type, and other information is only valid once the pen comes fully in range > so we should be careful to not use this information until that point. > > In particular, this issue may cause the driver to incorectly report > BTN_TOOL_RUBBER after switching from the eraser tool back to the pen. > > Fixes: a48324de6d4d ("HID: wacom: Bluetooth IRQ for Intuos Pro should handle prox/range") > Cc: # 4.11+ > Signed-off-by: Jason Gerecke > Reviewed-by: Aaron Armstrong Skomra > Signed-off-by: Benjamin Tissoires > --- > Original commit in Linus' tree: 2cc08800a6b9fcda7c7afbcf2da1a6e8808da725 All 3 patches now applied, thanks. greg k-h