From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D75C43613 for ; Thu, 20 Jun 2019 18:09:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09EDD2082C for ; Thu, 20 Jun 2019 18:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561054186; bh=zcu4yxtJsx+AVeYMzqd5C3jKuyG8OpnTkaxcUbuioDM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fPy0xOsxHNEnCxZQcK/MAkhv310xrJCuO+GbBcD/rw98ZrqkkO47MBzWrCF9K2h57 3Z+nuxwMjeTKlaa9t6Fzt73NK8/vIvYZLEyOw6VtSh+3SN+mmM9ygv9a59QASht2iZ SwIVd5FH/t4yF3AHf76qWGgOFmpusktFjG15UFCM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728681AbfFTSJp (ORCPT ); Thu, 20 Jun 2019 14:09:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:37222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbfFTSJo (ORCPT ); Thu, 20 Jun 2019 14:09:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 718E62082C; Thu, 20 Jun 2019 18:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561054183; bh=zcu4yxtJsx+AVeYMzqd5C3jKuyG8OpnTkaxcUbuioDM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XjWFTf2NskXJl0uGTGkpZZ8TeOJXVtdHrH55ifpPU661EUh4yf8rusL1IgMtn06FA Sl1GtTo6TwadittPtL1JV+VloyPc5kVLItIsT4pTZQVtbk787oWL/tWirkp5VrcpJr nI7EBjC6vithSk7i2psUYQmWqf7GjBk2jKA/DlEc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bard Liao , Takashi Iwai , Sasha Levin Subject: [PATCH 4.14 26/45] ALSA: hda - Force polling mode on CNL for fixing codec communication Date: Thu, 20 Jun 2019 19:57:28 +0200 Message-Id: <20190620174338.603309659@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190620174328.608036501@linuxfoundation.org> References: <20190620174328.608036501@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit fa763f1b2858752e6150ffff46886a1b7faffc82 ] We observed the same issue as reported by commit a8d7bde23e7130686b7662 ("ALSA: hda - Force polling mode on CFL for fixing codec communication") We don't have a better solution. So apply the same workaround to CNL. Signed-off-by: Bard Liao Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/hda_intel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 65fb1e7edb9c..d349f69ef03c 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -376,6 +376,7 @@ enum { #define IS_BXT(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x5a98) #define IS_CFL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa348) +#define IS_CNL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x9dc8) static char *driver_short_names[] = { [AZX_DRIVER_ICH] = "HDA Intel", @@ -1751,8 +1752,8 @@ static int azx_create(struct snd_card *card, struct pci_dev *pci, else chip->bdl_pos_adj = bdl_pos_adj[dev]; - /* Workaround for a communication error on CFL (bko#199007) */ - if (IS_CFL(pci)) + /* Workaround for a communication error on CFL (bko#199007) and CNL */ + if (IS_CFL(pci) || IS_CNL(pci)) chip->polling_mode = 1; err = azx_bus_init(chip, model[dev], &pci_hda_io_ops); -- 2.20.1