From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F18C43613 for ; Thu, 20 Jun 2019 18:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66537214AF for ; Thu, 20 Jun 2019 18:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561053615; bh=WsPLfgBAEBmpTq68qUbNRWJh0JBq5hVy9+FUFKzH7gI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Y3D2+o+8xDRzNZGVL05+wAtPNmuuvIN/Q8jSwdv2vgJG1AuZh3ZkaItdu1m9+t6Ku sBrKYjV92/FGPA2BZjsijTOQ/XFL9ag/YSAbGVZHO8zPiJv++9mhg8Bb7OokoV3OPH dveh+LvoUvuVABHCg5m2W5m1rN561PZ6MjlxeiN4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbfFTSAO (ORCPT ); Thu, 20 Jun 2019 14:00:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:48762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726159AbfFTSAN (ORCPT ); Thu, 20 Jun 2019 14:00:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7650F21530; Thu, 20 Jun 2019 18:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561053613; bh=WsPLfgBAEBmpTq68qUbNRWJh0JBq5hVy9+FUFKzH7gI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lDwe7ksfjOxCIGkDdeccfqPnjXRf/KdUqKD2xOinpuq1YJuF77US60sJlPK7z6iGT 8xU05jlvcBnqYChlvRsvx6A5AAMKe7ItWWTT+PLut2HF/js0TY5Us3iwRad7pPJftQ okZl3ubr+j48yFNZrSVQz0h1YAlxzM+iljFA8Lsw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dick Kennedy , James Smart , Bart Van Assche , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 51/84] scsi: lpfc: add check for loss of ndlp when sending RRQ Date: Thu, 20 Jun 2019 19:56:48 +0200 Message-Id: <20190620174346.566882359@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190620174337.538228162@linuxfoundation.org> References: <20190620174337.538228162@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit c8cb261a072c88ca1aff0e804a30db4c7606521b ] There was a missing qualification of a valid ndlp structure when calling to send an RRQ for an abort. Add the check. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Tested-by: Bart Van Assche Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_els.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 398c9a0a5ade..82a690924f5e 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -6498,7 +6498,10 @@ int lpfc_send_rrq(struct lpfc_hba *phba, struct lpfc_node_rrq *rrq) { struct lpfc_nodelist *ndlp = lpfc_findnode_did(rrq->vport, - rrq->nlp_DID); + rrq->nlp_DID); + if (!ndlp) + return 1; + if (lpfc_test_rrq_active(phba, ndlp, rrq->xritag)) return lpfc_issue_els_rrq(rrq->vport, ndlp, rrq->nlp_DID, rrq); -- 2.20.1