From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 165D8C48BEA for ; Mon, 24 Jun 2019 10:02:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4DF62146E for ; Mon, 24 Jun 2019 10:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370563; bh=Xob4prRYpzGNCy0BfQoNaMaioIygswDmCuiakzquiK4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZGbun7E/hB5PBbkq2mvI7FqdfldNruLTuQCXN+wNX8EtsMRBf6hmZCDd+PSxReaTz 3kbNIsemTwJTmPMMZOSHDqkbCrSBjiS3IJf4FyYkO1LnlQQRZhi6YT9JUMBX1GVvkc 5XBU5gp3J20HSYw3To70W9PmBcVo1MxrxmeDPg08= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729420AbfFXKCn (ORCPT ); Mon, 24 Jun 2019 06:02:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:33934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729412AbfFXKCm (ORCPT ); Mon, 24 Jun 2019 06:02:42 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 960BD2145D; Mon, 24 Jun 2019 10:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370561; bh=Xob4prRYpzGNCy0BfQoNaMaioIygswDmCuiakzquiK4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aqfBVj7ZRiyYuGHkzxXHgRQ9BLbFOK+q8WEiHPZgLZtlNDi4w+ohJ5HKUOdUbeLSK JT7YgDyPjfVWRQTFU2OcUGiUnyhE/B6ON0m6RJLfVwGoyvhMAtegjtWcHLtH0TFreW i9IJSAU+V8A8yPo7KhCzgZ8dVbf+lGvNCEn4GISE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mike Marciniszyn , Kaike Wan , Dennis Dalessandro , Jason Gunthorpe Subject: [PATCH 4.19 20/90] IB/hfi1: Validate fault injection opcode user input Date: Mon, 24 Jun 2019 17:56:10 +0800 Message-Id: <20190624092315.353216630@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190624092313.788773607@linuxfoundation.org> References: <20190624092313.788773607@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kaike Wan commit 5f90677ed31963abb184ee08ebee4a4a68225dd8 upstream. The opcode range for fault injection from user should be validated before it is applied to the fault->opcodes[] bitmap to avoid out-of-bound error. Cc: Fixes: a74d5307caba ("IB/hfi1: Rework fault injection machinery") Reported-by: Dan Carpenter Reviewed-by: Mike Marciniszyn Signed-off-by: Kaike Wan Signed-off-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/hfi1/fault.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/infiniband/hw/hfi1/fault.c +++ b/drivers/infiniband/hw/hfi1/fault.c @@ -153,6 +153,7 @@ static ssize_t fault_opcodes_write(struc char *dash; unsigned long range_start, range_end, i; bool remove = false; + unsigned long bound = 1U << BITS_PER_BYTE; end = strchr(ptr, ','); if (end) @@ -178,6 +179,10 @@ static ssize_t fault_opcodes_write(struc BITS_PER_BYTE); break; } + /* Check the inputs */ + if (range_start >= bound || range_end >= bound) + break; + for (i = range_start; i <= range_end; i++) { if (remove) clear_bit(i, fault->opcodes);