From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76AD9C48BE9 for ; Mon, 24 Jun 2019 10:04:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45FBA208E4 for ; Mon, 24 Jun 2019 10:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370660; bh=pRnKOdPQl7hC2q6F+bPvTomDy/40Pc8baQlM3LhR8NE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DvgXjcncfSkysSsNEeavtt0+cy6atDL9clei3DqFihxBDpbRmj+N1tQ38Cy88X+3F u4VAuLKi6dIP9rpMSThDTx2RbdCgtZBweFJ9fCj3KSokvJZYkA004AXvexdUW4iIC5 y3A+PmJNH2X8F3aMKWqoPPXKuiuRz4hxQp29kf+0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728909AbfFXKES (ORCPT ); Mon, 24 Jun 2019 06:04:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:35760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729658AbfFXKES (ORCPT ); Mon, 24 Jun 2019 06:04:18 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6817A20848; Mon, 24 Jun 2019 10:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370657; bh=pRnKOdPQl7hC2q6F+bPvTomDy/40Pc8baQlM3LhR8NE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hFyB9VJaAbNXYIf0X/BLHws8KkRiTxGoYGlW0L5Z+xEwR6nVnBZv5XSO5+MsXsxgt 9chZ9XHhKi+YGOiDXVdBZII6UP+Gp4/sSmf8vryOmAF1lHdm6iY5uaVYa7rQfeQO5z lnof1nR98GjFDopsdtGO3xuHIjp5dMsZUoaN9iWI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Michael J. Ruhl" , Kamenee Arumugam , Dennis Dalessandro , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.19 42/90] IB/hfi1: Validate page aligned for a given virtual address Date: Mon, 24 Jun 2019 17:56:32 +0800 Message-Id: <20190624092317.051419705@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190624092313.788773607@linuxfoundation.org> References: <20190624092313.788773607@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 97736f36dbebf2cda2799db3b54717ba5b388255 ] User applications can register memory regions for TID buffers that are not aligned on page boundaries. Hfi1 is expected to pin those pages in memory and cache the pages with mmu_rb. The rb tree will fail to insert pages that are not aligned correctly. Validate whether a given virtual address is page aligned before pinning. Fixes: 7e7a436ecb6e ("staging/hfi1: Add TID entry program function body") Reviewed-by: Michael J. Ruhl Signed-off-by: Kamenee Arumugam Signed-off-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c b/drivers/infiniband/hw/hfi1/user_exp_rcv.c index dbe7d14a5c76..4e986ca4dd35 100644 --- a/drivers/infiniband/hw/hfi1/user_exp_rcv.c +++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.c @@ -324,6 +324,9 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd, u32 *tidlist = NULL; struct tid_user_buf *tidbuf; + if (!PAGE_ALIGNED(tinfo->vaddr)) + return -EINVAL; + tidbuf = kzalloc(sizeof(*tidbuf), GFP_KERNEL); if (!tidbuf) return -ENOMEM; -- 2.20.1