From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26488C4321A for ; Fri, 28 Jun 2019 14:14:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2F7F2133F for ; Fri, 28 Jun 2019 14:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561731276; bh=hefLPdEcOKchEjgV2gdWc85+Zibje5sd/6U4PZNZnJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jKRV8mGcH0s8GnBJ6W55zRLKOiM0TJm2ux54c/N8se48jqdmF4S8cOgdvspGzLCfc ETAhNEQEX70rkfxNdp+ud1Xlwi+mAkqD/GFrHP+cAmmH6pzFXYcMKYGtqcNENG2cwu mM0/SLItASGs/fIi10UI5PCMGX70lPNogEkzqrG0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726712AbfF1OOf (ORCPT ); Fri, 28 Jun 2019 10:14:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:60950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726616AbfF1OOf (ORCPT ); Fri, 28 Jun 2019 10:14:35 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 24206208E3; Fri, 28 Jun 2019 14:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561731274; bh=hefLPdEcOKchEjgV2gdWc85+Zibje5sd/6U4PZNZnJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1yoxf46J5yK5R3nFcE9FcmHoQpH43hM27S7/4KuQHWf/5l2oI/2GwuDE+oAYO3Os5 lmhtAuTa+OGH5RZOgEW7RP4o52e6PUHx+Jgxc6S1opjBodFF25TYytz0iGTB1BYOVI leDQpRx+jAa2RYL1Nz5IYZw6TIsI6zcoupPbL49g= Date: Fri, 28 Jun 2019 10:14:33 -0400 From: Sasha Levin To: Kristian Evensen Cc: stable , =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH] qmi_wwan: Fix out-of-bounds read Message-ID: <20190628141433.GF11506@sasha-vm> References: <20190627100105.11517-1-kristian.evensen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jun 28, 2019 at 06:14:33AM +0200, Kristian Evensen wrote: >Hi, > >On Thu, Jun 27, 2019 at 12:01 PM Kristian Evensen > wrote: >> >> commit 904d88d743b0c94092c5117955eab695df8109e8 upstream. >> >> The syzbot reported >> >> Call Trace: >> __dump_stack lib/dump_stack.c:77 [inline] >> dump_stack+0xca/0x13e lib/dump_stack.c:113 >> print_address_description+0x67/0x231 mm/kasan/report.c:188 >> __kasan_report.cold+0x1a/0x32 mm/kasan/report.c:317 >> kasan_report+0xe/0x20 mm/kasan/common.c:614 >> qmi_wwan_probe+0x342/0x360 drivers/net/usb/qmi_wwan.c:1417 >> usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 >> really_probe+0x281/0x660 drivers/base/dd.c:509 >> driver_probe_device+0x104/0x210 drivers/base/dd.c:670 >> __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:777 >> bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454 >> >> Caused by too many confusing indirections and casts. >> id->driver_info is a pointer stored in a long. We want the >> pointer here, not the address of it. >> >> Thanks-to: Hillf Danton >> Reported-by: syzbot+b68605d7fadd21510de1@syzkaller.appspotmail.com >> Cc: Kristian Evensen >> Fixes: e4bf63482c30 ("qmi_wwan: Add quirk for Quectel dynamic config") >> Signed-off-by: Bjørn Mork >> >> [Upstream commit did not apply because I shuffled two lines in the >> backport. The fixes tag for 4.14 is 3a6a5107ceb3.] >> >> Signed-off-by: Kristian Evensen >> --- > >I see now that I forgot to set the correct prefix for the patch. The >prefix should be PATCH 4.14. Sorry about that. Please let me know if I >should resubmit. I've also queued the upstream fix to 5.1 and 4.19. -- Thanks, Sasha