From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB38C06510 for ; Tue, 2 Jul 2019 08:05:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E86472184B for ; Tue, 2 Jul 2019 08:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562054731; bh=2bcg2DM1IE8ugKmuof6Mw84sS9E6si19t81ORiMJElU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=F5lqPl+1P351pgyACwmfaciPPHWLpORIepK7XOqO6kZjFFMnVd1ssPz/xHnYbzLEP jvBnfHnWEMAnTFZvijPKVZ8/ciGRz2D+k5y9aTHAGsEx34qp6HKt7oVkfEMG7kzfRH FHBMwZTvrmpeNzu13mCoV/b7d1NOPg1UKZgRXRUU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727443AbfGBIF3 (ORCPT ); Tue, 2 Jul 2019 04:05:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:51554 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727952AbfGBIF2 (ORCPT ); Tue, 2 Jul 2019 04:05:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 739022183F; Tue, 2 Jul 2019 08:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562054727; bh=2bcg2DM1IE8ugKmuof6Mw84sS9E6si19t81ORiMJElU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n1Ce/pJ74JjRYsYONZJjZQzijDDeYgMgtIdZJ/CBCeXF1W0ScE2GL3mxaXkfIu41U Gr1ciBPpezUCBYk5qnAVS6rJIYjTHHgiKYZEC/QCoCTBCvNDLJKexs5hPLJoNuKMBs eNEQ9x9j9mnN7sNEVTEuKPFeQJ6QiBCjVzgYHUUc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dominique Martinet , Sasha Levin Subject: [PATCH 4.19 15/72] 9p: acl: fix uninitialized iattr access Date: Tue, 2 Jul 2019 10:01:16 +0200 Message-Id: <20190702080125.404250585@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190702080124.564652899@linuxfoundation.org> References: <20190702080124.564652899@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit e02a53d92e197706cad1627bd84705d4aa20a145 ] iattr is passed to v9fs_vfs_setattr_dotl which does send various values from iattr over the wire, even if it tells the server to only look at iattr.ia_valid fields this could leak some stack data. Link: http://lkml.kernel.org/r/1536339057-21974-2-git-send-email-asmadeus@codewreck.org Addresses-Coverity-ID: 1195601 ("Uninitalized scalar variable") Signed-off-by: Dominique Martinet Signed-off-by: Sasha Levin --- fs/9p/acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/acl.c b/fs/9p/acl.c index 082d227fa56b..6261719f6f2a 100644 --- a/fs/9p/acl.c +++ b/fs/9p/acl.c @@ -276,7 +276,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler, switch (handler->flags) { case ACL_TYPE_ACCESS: if (acl) { - struct iattr iattr; + struct iattr iattr = { 0 }; struct posix_acl *old_acl = acl; retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl); -- 2.20.1