From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 228DDC5B57D for ; Tue, 2 Jul 2019 08:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6531206A2 for ; Tue, 2 Jul 2019 08:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562055300; bh=tmrRpToP0yBZBOWOYKJ630REmNkOgHXMERgKfsDOU+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DqJYxiJY9b4Z4w+7HcE7KB/738S8YG6e5ZYFb+v27txTTWWaef6bR/WWCO/j/rs8M Tas0VWn5FQiYEikU6zb7VhsjHtegux5a0/vH2jM0YkOzyAXZyH9XXxg02DaroBGjGU GCguTeTtPNMawDEQNH+8rhPS7J+HNAbgAEx5ZKuM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbfGBIFc (ORCPT ); Tue, 2 Jul 2019 04:05:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:51642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727965AbfGBIFb (ORCPT ); Tue, 2 Jul 2019 04:05:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8415C21479; Tue, 2 Jul 2019 08:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562054731; bh=tmrRpToP0yBZBOWOYKJ630REmNkOgHXMERgKfsDOU+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sPlBJ/A5VTotnJYtnO+5TNWFqvkOC7I/EDN3sqdxjs6g086PS5Gr3LTJYzlVoJjs0 xCrzwLIiFV4WGbXGIQtU8e9Z0SX2mAmZQB9AkQxqdKCRPn9vaq//8om3pkF0o8cTgX OQGj0lKAl2FMqB5WChol3wON+DGdA2Wa0o/PCT2A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dominique Martinet , Sasha Levin Subject: [PATCH 4.19 16/72] 9p/rdma: remove useless check in cm_event_handler Date: Tue, 2 Jul 2019 10:01:17 +0200 Message-Id: <20190702080125.471040955@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190702080124.564652899@linuxfoundation.org> References: <20190702080124.564652899@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 473c7dd1d7b59ff8f88a5154737e3eac78a96e5b ] the client c is always dereferenced to get the rdma struct, so c has to be a valid pointer at this point. Gcc would optimize that away but let's make coverity happy... Link: http://lkml.kernel.org/r/1536339057-21974-3-git-send-email-asmadeus@codewreck.org Addresses-Coverity-ID: 102778 ("Dereference before null check") Signed-off-by: Dominique Martinet Signed-off-by: Sasha Levin --- net/9p/trans_rdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c index 9719bc4d9424..119103bfa82e 100644 --- a/net/9p/trans_rdma.c +++ b/net/9p/trans_rdma.c @@ -274,8 +274,7 @@ p9_cm_event_handler(struct rdma_cm_id *id, struct rdma_cm_event *event) case RDMA_CM_EVENT_DISCONNECTED: if (rdma) rdma->state = P9_RDMA_CLOSED; - if (c) - c->status = Disconnected; + c->status = Disconnected; break; case RDMA_CM_EVENT_TIMEWAIT_EXIT: -- 2.20.1