* [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio [not found] <20190706151900.14355-1-josua@solid-run.com> @ 2019-07-06 15:18 ` josua 2019-07-06 15:47 ` Andrew Lunn 2019-07-09 1:32 ` Rob Herring 2019-07-06 15:18 ` [PATCH 2/4] net: mvmdio: allow up to four clocks to be specified " josua [not found] ` <20190709130101.5160-1-josua@solid-run.com> 2 siblings, 2 replies; 11+ messages in thread From: josua @ 2019-07-06 15:18 UTC (permalink / raw) To: netdev; +Cc: Josua Mayer, stable, David S. Miller, Rob Herring, Mark Rutland From: Josua Mayer <josua@solid-run.com> Armada 8040 needs four clocks to be enabled for MDIO accesses to work. Update the binding to allow the extra clock to be specified. Cc: stable@vger.kernel.org Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for orion-mdio") Signed-off-by: Josua Mayer <josua@solid-run.com> --- Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt index 42cd81090a2c..3f3cfc1d8d4d 100644 --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt @@ -16,7 +16,7 @@ Required properties: Optional properties: - interrupts: interrupt line number for the SMI error/done interrupt -- clocks: phandle for up to three required clocks for the MDIO instance +- clocks: phandle for up to four required clocks for the MDIO instance The child nodes of the MDIO driver are the individual PHY devices connected to this MDIO bus. They must have a "reg" property given the -- 2.16.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio 2019-07-06 15:18 ` [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio josua @ 2019-07-06 15:47 ` Andrew Lunn 2019-07-09 1:32 ` Rob Herring 1 sibling, 0 replies; 11+ messages in thread From: Andrew Lunn @ 2019-07-06 15:47 UTC (permalink / raw) To: josua; +Cc: netdev, stable, David S. Miller, Rob Herring, Mark Rutland On Sat, Jul 06, 2019 at 05:18:57PM +0200, josua@solid-run.com wrote: > From: Josua Mayer <josua@solid-run.com> > > Armada 8040 needs four clocks to be enabled for MDIO accesses to work. > Update the binding to allow the extra clock to be specified. > > Cc: stable@vger.kernel.org > Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for orion-mdio") > Signed-off-by: Josua Mayer <josua@solid-run.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio 2019-07-06 15:18 ` [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio josua 2019-07-06 15:47 ` Andrew Lunn @ 2019-07-09 1:32 ` Rob Herring 2019-07-09 2:41 ` Andrew Lunn 1 sibling, 1 reply; 11+ messages in thread From: Rob Herring @ 2019-07-09 1:32 UTC (permalink / raw) To: josua; +Cc: netdev, stable, David S. Miller, Mark Rutland On Sat, Jul 6, 2019 at 9:31 AM <josua@solid-run.com> wrote: > > From: Josua Mayer <josua@solid-run.com> > > Armada 8040 needs four clocks to be enabled for MDIO accesses to work. > Update the binding to allow the extra clock to be specified. > > Cc: stable@vger.kernel.org > Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for orion-mdio") > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > index 42cd81090a2c..3f3cfc1d8d4d 100644 > --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt > @@ -16,7 +16,7 @@ Required properties: > > Optional properties: > - interrupts: interrupt line number for the SMI error/done interrupt > -- clocks: phandle for up to three required clocks for the MDIO instance > +- clocks: phandle for up to four required clocks for the MDIO instance This needs to enumerate exactly what the clocks are. Shouldn't there be an additional clock-names value too? Rob ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio 2019-07-09 1:32 ` Rob Herring @ 2019-07-09 2:41 ` Andrew Lunn 2019-07-09 22:03 ` Rob Herring 0 siblings, 1 reply; 11+ messages in thread From: Andrew Lunn @ 2019-07-09 2:41 UTC (permalink / raw) To: Rob Herring; +Cc: josua, netdev, stable, David S. Miller, Mark Rutland > > Optional properties: > > - interrupts: interrupt line number for the SMI error/done interrupt > > -- clocks: phandle for up to three required clocks for the MDIO instance > > +- clocks: phandle for up to four required clocks for the MDIO instance > > This needs to enumerate exactly what the clocks are. Shouldn't there > be an additional clock-names value too? Hi Rob The driver does not care what they are called. It just turns them all on, and turns them off again when removed. Andrew ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio 2019-07-09 2:41 ` Andrew Lunn @ 2019-07-09 22:03 ` Rob Herring 2019-07-18 1:31 ` Andrew Lunn 0 siblings, 1 reply; 11+ messages in thread From: Rob Herring @ 2019-07-09 22:03 UTC (permalink / raw) To: Andrew Lunn; +Cc: josua, netdev, stable, David S. Miller, Mark Rutland On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > Optional properties: > > > - interrupts: interrupt line number for the SMI error/done interrupt > > > -- clocks: phandle for up to three required clocks for the MDIO instance > > > +- clocks: phandle for up to four required clocks for the MDIO instance > > > > This needs to enumerate exactly what the clocks are. Shouldn't there > > be an additional clock-names value too? > > Hi Rob > > The driver does not care what they are called. It just turns them all > on, and turns them off again when removed. That's fine for the driver to do, but this is the hardware description. It's not just what they are called, but how many too. Is 1 clock in the DT valid? 0? It would be unusual for a given piece of h/w to function with a variable number of clocks. Rob ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio 2019-07-09 22:03 ` Rob Herring @ 2019-07-18 1:31 ` Andrew Lunn 0 siblings, 0 replies; 11+ messages in thread From: Andrew Lunn @ 2019-07-18 1:31 UTC (permalink / raw) To: Rob Herring; +Cc: josua, netdev, stable, David S. Miller, Mark Rutland On Tue, Jul 09, 2019 at 04:03:28PM -0600, Rob Herring wrote: > On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > > > Optional properties: > > > > - interrupts: interrupt line number for the SMI error/done interrupt > > > > -- clocks: phandle for up to three required clocks for the MDIO instance > > > > +- clocks: phandle for up to four required clocks for the MDIO instance > > > > > > This needs to enumerate exactly what the clocks are. Shouldn't there > > > be an additional clock-names value too? > > > > Hi Rob > > > > The driver does not care what they are called. It just turns them all > > on, and turns them off again when removed. > > That's fine for the driver to do, but this is the hardware description. > > It's not just what they are called, but how many too. Is 1 clock in > the DT valid? 0? It would be unusual for a given piece of h/w to > function with a variable number of clocks. Hi Rob The orion5x has 0 clocks. kirkwood, dove, Armada XP, 370 375, 380 has 1 clock. Armada 37xx has 4. So yes, 1 clock is valid. 0 clocks is also valid. The piece of hardware itself does not care how many clocks are feeding it, so long as they are all turned on. Andrew ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/4] net: mvmdio: allow up to four clocks to be specified for orion-mdio [not found] <20190706151900.14355-1-josua@solid-run.com> 2019-07-06 15:18 ` [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio josua @ 2019-07-06 15:18 ` josua 2019-07-06 15:47 ` Andrew Lunn [not found] ` <20190709130101.5160-1-josua@solid-run.com> 2 siblings, 1 reply; 11+ messages in thread From: josua @ 2019-07-06 15:18 UTC (permalink / raw) To: netdev; +Cc: Josua Mayer, stable, David S. Miller From: Josua Mayer <josua@solid-run.com> Allow up to four clocks to be specified and enabled for the orion-mdio interface, which are required by the Armada 8k and defined in armada-cp110.dtsi. Fixes a hang in probing the mvmdio driver that was encountered on the Clearfog GT 8K with all drivers built as modules, but also affects other boards such as the MacchiatoBIN. Cc: stable@vger.kernel.org Fixes: 96cb43423822 ("net: mvmdio: allow up to three clocks to be specified for orion-mdio") Signed-off-by: Josua Mayer <josua@solid-run.com> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index c5dac6bd2be4..e17d563e97a6 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -64,7 +64,7 @@ struct orion_mdio_dev { void __iomem *regs; - struct clk *clk[3]; + struct clk *clk[4]; /* * If we have access to the error interrupt pin (which is * somewhat misnamed as it not only reflects internal errors -- 2.16.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/4] net: mvmdio: allow up to four clocks to be specified for orion-mdio 2019-07-06 15:18 ` [PATCH 2/4] net: mvmdio: allow up to four clocks to be specified " josua @ 2019-07-06 15:47 ` Andrew Lunn 0 siblings, 0 replies; 11+ messages in thread From: Andrew Lunn @ 2019-07-06 15:47 UTC (permalink / raw) To: josua; +Cc: netdev, stable, David S. Miller On Sat, Jul 06, 2019 at 05:18:58PM +0200, josua@solid-run.com wrote: > From: Josua Mayer <josua@solid-run.com> > > Allow up to four clocks to be specified and enabled for the orion-mdio > interface, which are required by the Armada 8k and defined in > armada-cp110.dtsi. > > Fixes a hang in probing the mvmdio driver that was encountered on the > Clearfog GT 8K with all drivers built as modules, but also affects other > boards such as the MacchiatoBIN. > > Cc: stable@vger.kernel.org > Fixes: 96cb43423822 ("net: mvmdio: allow up to three clocks to be specified for orion-mdio") > Signed-off-by: Josua Mayer <josua@solid-run.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20190709130101.5160-1-josua@solid-run.com>]
* [PATCH v2 1/4] dt-bindings: allow up to four clocks for orion-mdio [not found] ` <20190709130101.5160-1-josua@solid-run.com> @ 2019-07-09 13:00 ` josua 2019-07-09 22:07 ` Rob Herring 2019-07-09 13:00 ` [PATCH v2 2/4] net: mvmdio: allow up to four clocks to be specified " josua 1 sibling, 1 reply; 11+ messages in thread From: josua @ 2019-07-09 13:00 UTC (permalink / raw) To: netdev Cc: Josua Mayer, stable, David S. Miller, Rob Herring, Mark Rutland, Andrew Lunn From: Josua Mayer <josua@solid-run.com> Armada 8040 needs four clocks to be enabled for MDIO accesses to work. Update the binding to allow the extra clock to be specified. Cc: stable@vger.kernel.org Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for orion-mdio") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Josua Mayer <josua@solid-run.com> --- Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt index 42cd81090a2c..3f3cfc1d8d4d 100644 --- a/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt +++ b/Documentation/devicetree/bindings/net/marvell-orion-mdio.txt @@ -16,7 +16,7 @@ Required properties: Optional properties: - interrupts: interrupt line number for the SMI error/done interrupt -- clocks: phandle for up to three required clocks for the MDIO instance +- clocks: phandle for up to four required clocks for the MDIO instance The child nodes of the MDIO driver are the individual PHY devices connected to this MDIO bus. They must have a "reg" property given the -- 2.16.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: allow up to four clocks for orion-mdio 2019-07-09 13:00 ` [PATCH v2 1/4] dt-bindings: allow up to four clocks " josua @ 2019-07-09 22:07 ` Rob Herring 0 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2019-07-09 22:07 UTC (permalink / raw) To: josua; +Cc: netdev, stable, David S. Miller, Mark Rutland, Andrew Lunn On Tue, Jul 9, 2019 at 7:13 AM <josua@solid-run.com> wrote: > > From: Josua Mayer <josua@solid-run.com> > > Armada 8040 needs four clocks to be enabled for MDIO accesses to work. > Update the binding to allow the extra clock to be specified. > > Cc: stable@vger.kernel.org > Fixes: 6d6a331f44a1 ("dt-bindings: allow up to three clocks for orion-mdio") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Josua Mayer <josua@solid-run.com> > --- > Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please don't resend patches when the last one is still under discussion. Rob ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 2/4] net: mvmdio: allow up to four clocks to be specified for orion-mdio [not found] ` <20190709130101.5160-1-josua@solid-run.com> 2019-07-09 13:00 ` [PATCH v2 1/4] dt-bindings: allow up to four clocks " josua @ 2019-07-09 13:00 ` josua 1 sibling, 0 replies; 11+ messages in thread From: josua @ 2019-07-09 13:00 UTC (permalink / raw) To: netdev; +Cc: Josua Mayer, stable, David S. Miller, Andrew Lunn From: Josua Mayer <josua@solid-run.com> Allow up to four clocks to be specified and enabled for the orion-mdio interface, which are required by the Armada 8k and defined in armada-cp110.dtsi. Fixes a hang in probing the mvmdio driver that was encountered on the Clearfog GT 8K with all drivers built as modules, but also affects other boards such as the MacchiatoBIN. Cc: stable@vger.kernel.org Fixes: 96cb43423822 ("net: mvmdio: allow up to three clocks to be specified for orion-mdio") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Josua Mayer <josua@solid-run.com> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index c5dac6bd2be4..e17d563e97a6 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -64,7 +64,7 @@ struct orion_mdio_dev { void __iomem *regs; - struct clk *clk[3]; + struct clk *clk[4]; /* * If we have access to the error interrupt pin (which is * somewhat misnamed as it not only reflects internal errors -- 2.16.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-07-18 1:31 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190706151900.14355-1-josua@solid-run.com>
2019-07-06 15:18 ` [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio josua
2019-07-06 15:47 ` Andrew Lunn
2019-07-09 1:32 ` Rob Herring
2019-07-09 2:41 ` Andrew Lunn
2019-07-09 22:03 ` Rob Herring
2019-07-18 1:31 ` Andrew Lunn
2019-07-06 15:18 ` [PATCH 2/4] net: mvmdio: allow up to four clocks to be specified " josua
2019-07-06 15:47 ` Andrew Lunn
[not found] ` <20190709130101.5160-1-josua@solid-run.com>
2019-07-09 13:00 ` [PATCH v2 1/4] dt-bindings: allow up to four clocks " josua
2019-07-09 22:07 ` Rob Herring
2019-07-09 13:00 ` [PATCH v2 2/4] net: mvmdio: allow up to four clocks to be specified " josua
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).