* [PATCH] perf: assign proper ff->ph in perf_event__synthesize_features()
@ 2019-06-20 1:04 Song Liu
2019-07-06 17:17 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Song Liu @ 2019-06-20 1:04 UTC (permalink / raw)
To: linux-kernel
Cc: kernel-team, acme, davidca, jolsa, namhyung, Song Liu, stable
bpf/btf write_* functions need ff->ph->env.
With this missing, pipe-mode (perf record -o -) would crash like:
Program terminated with signal SIGSEGV, Segmentation fault.
This patch assign proper ph value to ff.
Cc: stable@vger.kernel.org #v5.1+
Fixes: 606f972b1361 ("perf bpf: Save bpf_prog_info information as headers to perf.data")
Reported-by: David Carrillo Cisneros <davidca@fb.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 06ddb6618ef3..5f1aa0284e1b 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -3684,6 +3684,7 @@ int perf_event__synthesize_features(struct perf_tool *tool,
return -ENOMEM;
ff.size = sz - sz_hdr;
+ ff.ph = &session->header;
for_each_set_bit(feat, header->adds_features, HEADER_FEAT_BITS) {
if (!feat_ops[feat].synthesize) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] perf: assign proper ff->ph in perf_event__synthesize_features()
2019-06-20 1:04 [PATCH] perf: assign proper ff->ph in perf_event__synthesize_features() Song Liu
@ 2019-07-06 17:17 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-07-06 17:17 UTC (permalink / raw)
To: Song Liu; +Cc: linux-kernel, kernel-team, davidca, jolsa, namhyung, stable
Em Wed, Jun 19, 2019 at 06:04:53PM -0700, Song Liu escreveu:
> bpf/btf write_* functions need ff->ph->env.
>
> With this missing, pipe-mode (perf record -o -) would crash like:
>
> Program terminated with signal SIGSEGV, Segmentation fault.
>
> This patch assign proper ph value to ff.
Thanks, applied.
- Arnaldo
> Cc: stable@vger.kernel.org #v5.1+
> Fixes: 606f972b1361 ("perf bpf: Save bpf_prog_info information as headers to perf.data")
> Reported-by: David Carrillo Cisneros <davidca@fb.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> tools/perf/util/header.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 06ddb6618ef3..5f1aa0284e1b 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -3684,6 +3684,7 @@ int perf_event__synthesize_features(struct perf_tool *tool,
> return -ENOMEM;
>
> ff.size = sz - sz_hdr;
> + ff.ph = &session->header;
>
> for_each_set_bit(feat, header->adds_features, HEADER_FEAT_BITS) {
> if (!feat_ops[feat].synthesize) {
> --
> 2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-06 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-20 1:04 [PATCH] perf: assign proper ff->ph in perf_event__synthesize_features() Song Liu
2019-07-06 17:17 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).