From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ED69C606C3 for ; Mon, 8 Jul 2019 15:39:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DF6A20665 for ; Mon, 8 Jul 2019 15:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562600363; bh=s1k1F5quKTgHa+VggIV+0M3Yj0ny8zHIvRpb5ldtwvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o08IEVvQ0/OmJFjvVKV7Va9ZjLPa4oKO+ynUk+SpAF8P8kfGJ2v5fWv+CBnrc8kzG VUP9YAKOqdT1kvumBzezzuLodMZNu/koY8yX+PPihqxo+liEwAV1b3FMor9jHXcJ/z TITPyxgqvg7N9wNteaHabicn3gf+2HAFYedfKtzk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728124AbfGHPjW (ORCPT ); Mon, 8 Jul 2019 11:39:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:58762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730734AbfGHP3y (ORCPT ); Mon, 8 Jul 2019 11:29:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 99393204EC; Mon, 8 Jul 2019 15:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562599793; bh=s1k1F5quKTgHa+VggIV+0M3Yj0ny8zHIvRpb5ldtwvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T5GM5kmXoArawUKlKVTaHarnFeqMP56o/py2k26fobtjcmGyotqerXLX9xQ1ysVRi CCcMCLttYwYS29sHWzKhjpDGa7XKLPKKuAAllpr472DtpOeFeZcqiHecS90/CQrWS2 +96MZZKndloChd8LKtCBsldgAPezO8LYxFMFJooM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Mukesh Ojha , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 79/90] net: hns: fix unsigned comparison to less than zero Date: Mon, 8 Jul 2019 17:13:46 +0200 Message-Id: <20190708150526.356784871@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190708150521.829733162@linuxfoundation.org> References: <20190708150521.829733162@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit ea401685a20b5d631957f024bda86e1f6118eb20 ] Currently mskid is unsigned and hence comparisons with negative error return values are always false. Fix this by making mskid an int. Fixes: f058e46855dc ("net: hns: fix ICMP6 neighbor solicitation messages discard problem") Addresses-Coverity: ("Operands don't affect result") Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index f5ff07cb2b72..f2b0b587a1be 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -2777,7 +2777,7 @@ static void set_promisc_tcam_enable(struct dsaf_device *dsaf_dev, u32 port) struct hns_mac_cb *mac_cb; u8 addr[ETH_ALEN] = {0}; u8 port_num; - u16 mskid; + int mskid; /* promisc use vague table match with vlanid = 0 & macaddr = 0 */ hns_dsaf_set_mac_key(dsaf_dev, &mac_key, 0x00, port, addr); -- 2.20.1