From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Enable PSR2 by default"
Date: Thu, 11 Jul 2019 04:02:01 -0700 [thread overview]
Message-ID: <20190711110201.GD9599@intel.com> (raw)
In-Reply-To: <20190711092254.1719-1-chris@chris-wilson.co.uk>
On Thu, Jul 11, 2019 at 10:22:54AM +0100, Chris Wilson wrote:
> Multiple users are reporting black screens upon boot, after resume, or
> frozen after a short period of idleness. A black screen on boot is a
> critical issue so disable psr2 again until resolved.
>
> This reverts commit 8f6e87d6d561f10cfa48a687345512419839b6d8.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111088
I agree it is critical, but unfortunately this revert won't solve the issue.
[ 1.954886] [drm:intel_psr_init_dpcd [i915]] eDP panel supports PSR version 1
[ 2.003686] [drm:intel_psr_enable_locked [i915]] Enabling PSR1
Users are claiming the regression is only on 5.2 with 5.1 working well
and PSR1 is enabled by default since 5.0.
A bisect would be good, but it seems a hard issue to reproduce as well
what makes things more difficult.
> Fixes: 8f6e87d6d561 ("drm/i915: Enable PSR2 by default")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: stable@vger.kernel.org #v5.2
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 69d908e6a050..ddde4da2de33 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -83,6 +83,9 @@ static bool intel_psr2_enabled(struct drm_i915_private *dev_priv,
> case I915_PSR_DEBUG_DISABLE:
> case I915_PSR_DEBUG_FORCE_PSR1:
> return false;
> + case I915_PSR_DEBUG_DEFAULT:
> + if (i915_modparams.enable_psr <= 0)
> + return false;
> default:
> return crtc_state->has_psr2;
> }
> --
> 2.22.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-11 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 9:22 [PATCH] drm/i915: Revert "drm/i915: Enable PSR2 by default" Chris Wilson
2019-07-11 11:02 ` Rodrigo Vivi [this message]
2019-07-11 11:08 ` [Intel-gfx] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711110201.GD9599@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox