From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC446C73C66 for ; Sun, 14 Jul 2019 15:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B82E620896 for ; Sun, 14 Jul 2019 15:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563116982; bh=bm9pEoqApX+qfkcBW1EqbTeake3cpyojbVnypkCIZzs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=JdZ2mvHdjr0lvqnqIG7QnpJSuSxMt5SxZdDmn/EMAJOTroE1Gh4oa+wZ08cxSuxZo 8LkP5/Yg4raM0ijrrYeoynUjEybzhx2M7lGCeqPkIDh6mr8m8jSaQvLtmhcGx9O7o3 zE2MeFjcBo2BbkT3BMT9tYo0mt683cTgR2LVJJqE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728534AbfGNPJe (ORCPT ); Sun, 14 Jul 2019 11:09:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:57824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728380AbfGNPJe (ORCPT ); Sun, 14 Jul 2019 11:09:34 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F2B92063F; Sun, 14 Jul 2019 15:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563116973; bh=bm9pEoqApX+qfkcBW1EqbTeake3cpyojbVnypkCIZzs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0eRUwZBYgVu2OLCbOTDh1MKwciFyHBtd8VCxW9LyL5hX9zdTvY4irReOkutgYDqGN jx2VGZACcSHrdEXXR4stGZTF2JkMoo4ULRTqQa9nxifkdWViBF3u77WAFTD3AkW4vC +94C+s3kNUg7ipIqG68DRzw76ooNnXv7Lv3nHex4= Date: Sun, 14 Jul 2019 16:09:08 +0100 From: Jonathan Cameron To: Wolfram Sang Cc: Marek Vasut , Geert Uytterhoeven , Arnd Bergmann , stable , Marek Vasut , Geert Uytterhoeven , Simon Horman , Linux-Renesas , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Kuninori Morimoto , linux-iio@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] iio: adc: gyroadc: fix uninitialized return code Message-ID: <20190714160908.7443eca6@archlinux> In-Reply-To: <20190704195557.GA1338@kunai> References: <20190704113800.3299636-1-arnd@arndb.de> <20190704120756.GA1582@kunai> <20190704195557.GA1338@kunai> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 4 Jul 2019 21:55:58 +0200 Wolfram Sang wrote: > > >> This is correct but missing that the above 'return ret' is broken, too. > > >> ret is initialized but 0 in that case. > > > > > > Nice catch! Oh well, given enough eyeballs, ... > > > > I don't think ret is initialized, reg is, not ret . > > It is initialized for the broken 'return ret' *above* the one which gets > rightfully fixed in this patch. > Agreed, 2 broken cases and this is only fixing the second one. I'm expecting a v2 of this patch which fixes them both, so won't apply this v1. Thanks, Jonathan