From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F5BC76191 for ; Mon, 15 Jul 2019 15:11:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C3DB2054F for ; Mon, 15 Jul 2019 15:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563203482; bh=OBNQ/TWhknx53Y4e0SQtL38O30mzkQx+LTCNyVXyWSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lXTnL8yOrD6nCJ50FT+SJuCxebzcWksyaZRkFBK3C9QTT5YboYAUNxRTwPM2VLJaK 1CQIX5wOSzpjCmfK0Jmsp+qtB2cgokPegCMCu/KsBa27LcuM6ZICajhXFvRQj45OmY kTq7P3yRJAfCCz4SxQvcfJwQ3iid34owCrAp5BUM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731690AbfGONya (ORCPT ); Mon, 15 Jul 2019 09:54:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:55328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730844AbfGONy3 (ORCPT ); Mon, 15 Jul 2019 09:54:29 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77DB52081C; Mon, 15 Jul 2019 13:54:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563198868; bh=OBNQ/TWhknx53Y4e0SQtL38O30mzkQx+LTCNyVXyWSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TGHCInWQcagB8AbAgd5e1dwYf2SIXdPaj3F8XQWI1WdKihdUQKmMV/u4seWISLmrS mvosTw36AYIHOsmvZDwh2HhM8Qf8JLrldI4Yz6MzZymSmfe5ojOQllokFBnvXB1SvW dTVwwlUW7/VUPJfeeO1xq6RLu6g9kjyKPwIYzW7E= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnaldo Carvalho de Melo , Adrian Hunter , Jiri Olsa , Namhyung Kim , Alexey Budankov , Sasha Levin Subject: [PATCH AUTOSEL 5.2 123/249] tools build: Fix the zstd test in the test-all.c common case feature test Date: Mon, 15 Jul 2019 09:44:48 -0400 Message-Id: <20190715134655.4076-123-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715134655.4076-1-sashal@kernel.org> References: <20190715134655.4076-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnaldo Carvalho de Melo [ Upstream commit 3469fa84c1631face938efc42b3f488a2c2504e0 ] We were renanimg 'main' to 'main_zstd' but then using 'main_libzstd();' in the main() for test-all.c, causing this: $ cat /tmp/build/perf/feature/test-all.make.output test-all.c: In function ‘main’: test-all.c:236:2: error: implicit declaration of function ‘main_test_libzstd’; did you mean ‘main_test_zstd’? [-Werror=implicit-function-declaration] main_test_libzstd(); ^~~~~~~~~~~~~~~~~ main_test_zstd cc1: all warnings being treated as errors $ I.e. what was supposed to be the fast path feature test was _always_ failing, duh, fix it. Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Cc: Alexey Budankov Fixes: 3b1c5d965971 ("tools build: Implement libzstd feature check, LIBZSTD_DIR and NO_LIBZSTD defines") Link: https://lkml.kernel.org/n/tip-ma4abk0utroiw4mwpmvnjlru@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/build/feature/test-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/build/feature/test-all.c b/tools/build/feature/test-all.c index a59c53705093..939ac2fcc783 100644 --- a/tools/build/feature/test-all.c +++ b/tools/build/feature/test-all.c @@ -182,7 +182,7 @@ # include "test-disassembler-four-args.c" #undef main -#define main main_test_zstd +#define main main_test_libzstd # include "test-libzstd.c" #undef main -- 2.20.1