From: Leon Romanovsky <leon@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Selvin Xavier <selvin.xavier@broadcom.com>,
linux-rdma@vger.kernel.org, dledford@redhat.com, jgg@ziepe.ca,
linux-nvme@lists.infradead.org, stable@vger.kernel.org,
Parav Pandit <parav@mellanox.com>
Subject: Re: [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison
Date: Tue, 16 Jul 2019 11:41:26 +0300 [thread overview]
Message-ID: <20190716084126.GJ10130@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190716071644.GA21780@kroah.com>
On Tue, Jul 16, 2019 at 04:16:44PM +0900, Greg KH wrote:
> On Tue, Jul 16, 2019 at 10:10:30AM +0300, Leon Romanovsky wrote:
> > On Mon, Jul 15, 2019 at 05:19:13AM -0400, Selvin Xavier wrote:
> > > GID entry consist of GID, vlan, netdev and smac.
> > > Extend GID duplicate check companions to consider vlan_id as well
> > > to support IPv6 VLAN based link local addresses. Introduce
> > > a new structure (bnxt_qplib_gid_info) to hold gid and vlan_id information.
> > >
> > > The issue is discussed in the following thread
> > > https://www.spinics.net/lists/linux-rdma/msg81594.html
> > >
> > > Fixes: 823b23da7113 ("IB/core: Allow vlan link local address based RoCE GIDs")
> > > Cc: <stable@vger.kernel.org> # v5.2+
> > > Reported-by: Yi Zhang <yi.zhang@redhat.com>
> >
> > > Co-developed-by: Parav Pandit <parav@mellanox.com>
> > > Signed-off-by: Parav Pandit <parav@mellanox.com>
> >
> > I never understood why bad habits are so stinky.
> >
> > Can you please explain us what does it mean Co-developed-by and
> > Signed-off-by of the same person in the same patch?
>
> See Documentation/process/submitting-patches.rst for what that tag
> means.
Read it, it doesn't help me to understand if I should now add
Co-developed-by tag to most of RDMA Mellanox upstreamed patches,
which already care my Signed-off-by, because I'm changing and fixing
them many times.
Maybe I should write for my upstreamed patched something like this?
Co-developed-by: Leon R...
Reviewed-By: Leon R...
Tested-by: Leon R...
Signed-by: Leon R...
Thanks
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2019-07-16 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 9:19 [PATCH for-rc] RDMA/bnxt_re: Honor vlan_id in GID entry comparison Selvin Xavier
2019-07-15 14:17 ` Yi Zhang
2019-07-16 7:10 ` Leon Romanovsky
2019-07-16 7:16 ` Greg KH
2019-07-16 8:41 ` Leon Romanovsky [this message]
2019-07-16 9:09 ` Greg KH
2019-07-16 9:50 ` Leon Romanovsky
2019-07-16 9:58 ` Greg KH
2019-07-16 10:20 ` Leon Romanovsky
2019-07-22 18:07 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716084126.GJ10130@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=selvin.xavier@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).