From: Ross Zwisler <zwisler@google.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Ross Zwisler <zwisler@chromium.org>,
stable@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
Guenter Roeck <groeck@google.com>
Subject: Re: [v4.14.y PATCH 0/2] fix drm/udl use-after-free error
Date: Tue, 16 Jul 2019 10:08:28 -0600 [thread overview]
Message-ID: <20190716160828.GA13008@google.com> (raw)
In-Reply-To: <20190716011308.GA1943@sasha-vm>
On Mon, Jul 15, 2019 at 09:13:08PM -0400, Sasha Levin wrote:
> On Mon, Jul 15, 2019 at 01:36:16PM -0600, Ross Zwisler wrote:
> > This patch is the second in this series, and requires the first patch as
> > a dependency. This series apples cleanly to v4.14.133.
>
> Hm, we don't need ac3b35f11a06 here? Why not? I'd love to document that
> with the backport.
Nope, we don't need that patch in the v4.14 backport.
In v4.19.y we have two functions, drm_dev_put() and drm_dev_unref(), which are
aliases for one another (drm_dev_unref() just calls drm_dev_put()).
drm_dev_unref() is the older of the two, and was introduced back in v4.0.
drm_dev_put() was introduced in v4.15 with
9a96f55034e41 drm: introduce drm_dev_{get/put} functions
and slowly callers were moved from the old name (_unref) to the new name
(_put). The patch you mentioned, ac3b35f11a06, is one such patch where we are
replacing a drm_dev_unref() call with a drm_dev_put() call. This doesn't have
a functional change, but was necessary so that the third patch in the v4.19.y
series I sent would apply cleanly.
For the v4.14.y series, though, the drm_dev_put() function hasn't yet been
defined and everyone is still using drm_dev_unref(). So, we don't need a
backport of ac3b35f11a06, and I also had a small backport change in the last
patch of the v4.14.y series where I had to change a drm_dev_put() call with a
drm_dev_unref() call.
Just for posterity, the drm_dev_unref() calls were eventually all changed to
drm_dev_put() in v5.0, and drm_dev_unref() was removed entirely. That
happened with the following two patches:
808bad32ea423 drm: replace "drm_dev_unref" function with "drm_dev_put"
ba1d345401476 drm: remove deprecated "drm_dev_unref" function
next prev parent reply other threads:[~2019-07-16 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 19:36 [v4.14.y PATCH 0/2] fix drm/udl use-after-free error Ross Zwisler
2019-07-15 19:36 ` [v4.14.y PATCH 1/2] drm/udl: introduce a macro to convert dev to udl Ross Zwisler
2019-07-15 19:36 ` [v4.14.y PATCH 2/2] drm/udl: move to embedding drm device inside udl device Ross Zwisler
2019-07-16 1:13 ` [v4.14.y PATCH 0/2] fix drm/udl use-after-free error Sasha Levin
2019-07-16 16:08 ` Ross Zwisler [this message]
2019-07-17 23:28 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716160828.GA13008@google.com \
--to=zwisler@google.com \
--cc=airlied@redhat.com \
--cc=groeck@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).