From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D9A6C76186 for ; Thu, 18 Jul 2019 03:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0759521783 for ; Thu, 18 Jul 2019 03:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563420158; bh=8p4jojiR7Bb64yyMgrd8nS9JzGUKMIODQamu7Q/3LrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=P8r73D18XjljwMz9CCj03yPPd5q1qI34wZiGk6XK99dS+DSacrgJY7vG0zuxlXiyG w6Q4e4Xjt/8BYDknB7Vd+Av5QMP1FY+zZM0y/8iNdNYQ1kPxlTpoR8Ei5yWK24ZYIC UlHjH3bvqkB4dXjzWn9tLzObOdo3p7y1apHCtFBM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390298AbfGRDIl (ORCPT ); Wed, 17 Jul 2019 23:08:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:40796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390832AbfGRDIl (ORCPT ); Wed, 17 Jul 2019 23:08:41 -0400 Received: from localhost (115.42.148.210.bf.2iij.net [210.148.42.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FF912173E; Thu, 18 Jul 2019 03:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563419320; bh=8p4jojiR7Bb64yyMgrd8nS9JzGUKMIODQamu7Q/3LrU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fWnwI6G3d3uYO/YuNHjlPnHEKvUWAIqM9NUKiWitELaS9VEtI3CqNt0Ke3lPtYGAX QdQpvbe+aM1x9XPMwpKWODSl4XchtjVUDRz3b519Ih7OQEHQb6QR1Tc29cTBO5a0xO ULm4Wujyzc57jC+vv6VKeXANoFyExd3RQsr5vMOw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jia-Ju Bai , Luca Coelho , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 14/80] iwlwifi: Fix double-free problems in iwl_req_fw_callback() Date: Thu, 18 Jul 2019 12:01:05 +0900 Message-Id: <20190718030059.925355091@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190718030058.615992480@linuxfoundation.org> References: <20190718030058.615992480@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit a8627176b0de7ba3f4524f641ddff4abf23ae4e4 ] In the error handling code of iwl_req_fw_callback(), iwl_dealloc_ucode() is called to free data. In iwl_drv_stop(), iwl_dealloc_ucode() is called again, which can cause double-free problems. To fix this bug, the call to iwl_dealloc_ucode() in iwl_req_fw_callback() is deleted. This bug is found by a runtime fuzzing tool named FIZZER written by us. Signed-off-by: Jia-Ju Bai Signed-off-by: Luca Coelho Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index 99676d6c4713..6c10b8c4ddbe 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -1509,7 +1509,6 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context) goto free; out_free_fw: - iwl_dealloc_ucode(drv); release_firmware(ucode_raw); out_unbind: complete(&drv->request_firmware_complete); -- 2.20.1