From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62AE5C76186 for ; Thu, 18 Jul 2019 03:23:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3ADD420578 for ; Thu, 18 Jul 2019 03:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563420203; bh=+FI4n+PPYI8pv4UC2EHG4ZApCXRHUonsT00HyG0ndGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KJIKsIXGwg9SxKv1jUel82Y49XHQwK9perPQlYTO34AJf2w6QC26oqJaidshUW3qw 1+HMLU7jnXvS1z+5PyawChrEYjqn+jYZQ+ZnZpMhjnx3iUAUvMm3eu204xfDIJy2qG Az3gbbxrLxvd7u/+FcdK/onsM62ywSXX2IO9f4k4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389191AbfGRDVW (ORCPT ); Wed, 17 Jul 2019 23:21:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:42642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391070AbfGRDJt (ORCPT ); Wed, 17 Jul 2019 23:09:49 -0400 Received: from localhost (115.42.148.210.bf.2iij.net [210.148.42.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 560F420818; Thu, 18 Jul 2019 03:09:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563419388; bh=+FI4n+PPYI8pv4UC2EHG4ZApCXRHUonsT00HyG0ndGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2F9VdLrxrb4amjRucopTbZH0Gc60dO8/Lr6qG/Ch0A9EBNWSp1FvakVfdksXMOCmd TgqQTxQjQu7ExpnmoG6errHP5qYWQ0n+oexw8SLyq1Ud7DGXHHnUcEPKJZWnzx7Ejk FZQAn/NJCppaBRG5oK2OznY7COgVQafRqKkzpPtM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Dan Carpenter , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 36/80] net: lio_core: fix potential sign-extension overflow on large shift Date: Thu, 18 Jul 2019 12:01:27 +0900 Message-Id: <20190718030101.420382368@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190718030058.615992480@linuxfoundation.org> References: <20190718030058.615992480@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 9476274093a0e79b905f4cd6cf6d149f65e02c17 ] Left shifting the signed int value 1 by 31 bits has undefined behaviour and the shift amount oq_no can be as much as 63. Fix this by using BIT_ULL(oq_no) instead. Addresses-Coverity: ("Bad shift operation") Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters") Signed-off-by: Colin Ian King Reviewed-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c index 23f6b60030c5..8c16298a252d 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c @@ -854,7 +854,7 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct) if (droq->ops.poll_mode) { droq->ops.napi_fn(droq); - oct_priv->napi_mask |= (1 << oq_no); + oct_priv->napi_mask |= BIT_ULL(oq_no); } else { tasklet_schedule(&oct_priv->droq_tasklet); } -- 2.20.1