From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99286C76188 for ; Fri, 19 Jul 2019 04:21:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 733242082F for ; Fri, 19 Jul 2019 04:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563510072; bh=NKN2kMwDMv/CtJoT/kNNSdoQYzqkb1OZN7iL5M3DnOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pimYM+e4kst70fMzowfyXh5yXYVpeMlHUXgGdKZr1MzxXTZ2YQCZ1DJoKYUnJ+ccb aO7bQdPoD0hH5tTjw1+Kzp42PbW81/vIYh+t7n0F2C0d4qq3pEzUMQovbsATy/MP48 Gk+lb9o45UOXAQBRP2C7RoCw8iM2XdHvtI4jUXZE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729323AbfGSEVH (ORCPT ); Fri, 19 Jul 2019 00:21:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:47420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732862AbfGSEMK (ORCPT ); Fri, 19 Jul 2019 00:12:10 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DC7B21872; Fri, 19 Jul 2019 04:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509530; bh=NKN2kMwDMv/CtJoT/kNNSdoQYzqkb1OZN7iL5M3DnOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PoAwjjCp+Io96ivyMf/In1cpjbSBl9JM8biYDlVJXdv/AYQ2MkRQBh6mEI0j5MwLM 0WDWFyc6PMKXFYWr1Pqe+1xFX7lgcQGhsm7pH8ifspXuoWKTbHtJku4nVgN1R+3DEY xUrHI39+b9Rc0KlxzLGahiExdzyi2W4+cKtSW0NY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Robert Hancock , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.14 33/60] mfd: core: Set fwnode for created devices Date: Fri, 19 Jul 2019 00:10:42 -0400 Message-Id: <20190719041109.18262-33-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190719041109.18262-1-sashal@kernel.org> References: <20190719041109.18262-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Robert Hancock [ Upstream commit c176c6d7e932662668bcaec2d763657096589d85 ] The logic for setting the of_node on devices created by mfd did not set the fwnode pointer to match, which caused fwnode-based APIs to malfunction on these devices since the fwnode pointer was null. Fix this. Signed-off-by: Robert Hancock Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/mfd-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c index c57e407020f1..5c8ed2150c8b 100644 --- a/drivers/mfd/mfd-core.c +++ b/drivers/mfd/mfd-core.c @@ -179,6 +179,7 @@ static int mfd_add_device(struct device *parent, int id, for_each_child_of_node(parent->of_node, np) { if (of_device_is_compatible(np, cell->of_compatible)) { pdev->dev.of_node = np; + pdev->dev.fwnode = &np->fwnode; break; } } -- 2.20.1