From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC09DC76196 for ; Fri, 19 Jul 2019 04:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9500C2084C for ; Fri, 19 Jul 2019 04:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509898; bh=ZcxzPT1EV10ig9jC1fcvqMrYGzw9x8yUinG8TInND6Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oDDLVofl6fWQo6tMOIUzNE4YAjomgpS6kBPy7dVLJwoB5U+fgLCookCcHYq7Z0D1O 6ivnbGQaFYd8F2V2pRElaLUbkVDobSh8gQoLns89vXw1cWu7r7zQ3JlxYV2LSluNfe 1C7+0JWbgg2Y9OHDAB0bmdVhTps5xsTp5MEu5LRU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389396AbfGSENu (ORCPT ); Fri, 19 Jul 2019 00:13:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:49892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389384AbfGSENu (ORCPT ); Fri, 19 Jul 2019 00:13:50 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71967218BB; Fri, 19 Jul 2019 04:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563509629; bh=ZcxzPT1EV10ig9jC1fcvqMrYGzw9x8yUinG8TInND6Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1QPUjFEiZLUeorQM02HmskLlRKT8NZEktgiy89t/AJ7evdnUkSGp9QJolKap82jnl H+3ximXWw6CfRp+UmkNJO9bvETzDTJqy9CJaFBqyk6mdrcSYRPKuWpJDnoW7Pcu+7W JgyMvfc2yxwfCIGNC2NtZM6bmIDLMHvHC38EOmU0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Axel Lin , Chen Feng , Lee Jones , Sasha Levin Subject: [PATCH AUTOSEL 4.9 27/45] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk Date: Fri, 19 Jul 2019 00:12:46 -0400 Message-Id: <20190719041304.18849-27-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190719041304.18849-1-sashal@kernel.org> References: <20190719041304.18849-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Axel Lin [ Upstream commit 7efd105c27fd2323789b41b64763a0e33ed79c08 ] Since devm_regmap_init_mmio_clk can fail, add return value checking. Signed-off-by: Axel Lin Acked-by: Chen Feng Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/hi655x-pmic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 11347a3e6d40..c311b869be38 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -111,6 +111,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev) pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base, &hi655x_regmap_config); + if (IS_ERR(pmic->regmap)) + return PTR_ERR(pmic->regmap); regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver); if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) { -- 2.20.1