From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C4A6C76191 for ; Mon, 22 Jul 2019 00:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A9D220838 for ; Mon, 22 Jul 2019 00:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563755912; bh=GpZBe/mU9F6rGW/Fli0H0zLhqDf/3yS0fGD8fy4RP4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kmmCIeBsiN0Y1IMruffLo80Ya0KR9zP+Cpt5fiWfiNwgYBiKwHx+T4snvMYAM0m8z pVMGJKkfqvg664Nd30b1gXvEELtdgHGhTs5Ty+XyhlRb3LShM/Iu2XAmom45FHV6EQ v8twBZIYbK91xMjjybkshgtyA3+AFKkAfCNd46iA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbfGVAib (ORCPT ); Sun, 21 Jul 2019 20:38:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:47906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbfGVAib (ORCPT ); Sun, 21 Jul 2019 20:38:31 -0400 Received: from localhost (unknown [216.243.17.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61970206BF; Mon, 22 Jul 2019 00:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563755910; bh=GpZBe/mU9F6rGW/Fli0H0zLhqDf/3yS0fGD8fy4RP4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v5ABB0JnKaTX4+K9ZkC9f1xuPEc/MArnu+5GmX9I8bR0+YFLIU1SMIFkDFar50H/5 oLb703VMlHvdMhKhKj4fRYWUMeCeMD+YEb/vEc/qOEwd34IbNweQ9iv1158CICdv9A koMtFO3hfEbObUZdgI36pQClZmou1ye6qlqA1it8= Date: Sun, 21 Jul 2019 20:38:30 -0400 From: Sasha Levin To: Greg KH Cc: Linus Torvalds , stable Subject: Re: Floppy ioctl range clamping fixes Message-ID: <20190722003830.GA1607@sasha-vm> References: <20190719170718.GA32664@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190719170718.GA32664@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jul 19, 2019 at 07:07:18PM +0200, Greg KH wrote: >On Thu, Jul 18, 2019 at 09:29:06PM -0700, Linus Torvalds wrote: >> Hmm. I just realized when I saw Sasha's autoselect patches flying by >> that the floppy ioctl fixes didn't get marked for stable, but they >> probably should be. >> >> There's four commits: >> >> da99466ac243 floppy: fix out-of-bounds read in copy_buffer >> 9b04609b7840 floppy: fix invalid pointer dereference in drive_name >> 5635f897ed83 floppy: fix out-of-bounds read in next_valid_format >> f3554aeb9912 floppy: fix div-by-zero in setup_format_params >> >> that look like stable material - even if I sincerely hope that the >> floppy driver isn't critical for anybody. >> >> I leave it to the stable people to decide if they care. I don't think >> the hardware matters any more, but I could imagine that people still >> use it for some virtual images and have a floppy device inside a VM >> for that reason. > >Thanks for the reminder, I'll queue these up for the next round of >stable releases after the next ones go out in a day or so. I've queued them up, thanks! -- Thanks, Sasha