From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE55C76191 for ; Mon, 22 Jul 2019 00:39:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 029D5208E4 for ; Mon, 22 Jul 2019 00:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563755958; bh=60TYNH0hwVxrMOKDBgoWalRZn/KY6XzLLZo86nHK+LM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GdMHMgPsG7oRDNSv1QMiIRT9LO2KMVc1NXKFZCmUH5VHFH+5IIAuAp+ifZSoCcU9j /1qazHq8Z2UfouiHVbNVkI6tqLwlHHaf4IOA92DjX41O4FrzlOIElXZ27a4gg+F6nL nYCY8aBa0/8Zn+HuphnZiMeEs+9T/AnLR4Fu77g0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726360AbfGVAjR (ORCPT ); Sun, 21 Jul 2019 20:39:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:48662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbfGVAjR (ORCPT ); Sun, 21 Jul 2019 20:39:17 -0400 Received: from localhost (unknown [216.243.17.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DDFF206BF; Mon, 22 Jul 2019 00:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563755956; bh=60TYNH0hwVxrMOKDBgoWalRZn/KY6XzLLZo86nHK+LM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lfo6EjXKW20c9vdPwQ/x+i/OsajsnIlxT+hvZhHcp1MKfFvwz35oJ0dNXe1d21t0S wcAWQs09moHV8rCicrYM7YclAYr144eTJFpweoYi9MOYnIbe1GgI7hfApJ7aTm9LUu OAcEG4TRq3uVgRwmfM6BoxXsOrXWRJw1ZdsIyNNQ= Date: Sun, 21 Jul 2019 20:39:15 -0400 From: Sasha Levin To: Daniel Drake Cc: Linux Kernel , stable@vger.kernel.org, Thomas Gleixner , Andy Lutomirski , Borislav Petkov , "H . Peter Anvin" , Linus Torvalds , Peter Zijlstra , Len Brown , Linux Upstreaming Team , "Wysocki, Rafael J" , Ingo Molnar Subject: Re: [PATCH AUTOSEL 5.1 013/219] x86/tsc: Use CPUID.0x16 to calculate missing crystal frequency Message-ID: <20190722003915.GB1607@sasha-vm> References: <20190715133811.2441-1-sashal@kernel.org> <20190715133811.2441-13-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jul 16, 2019 at 10:56:59AM +0800, Daniel Drake wrote: >Hi, > >On Mon, Jul 15, 2019 at 9:38 PM Sasha Levin wrote: >> From: Daniel Drake >> >> [ Upstream commit 604dc9170f2435d27da5039a3efd757dceadc684 ] > >In my opinion this is not stable kernel material. > >It alone does not solve a particular bug. It's part of a larger effort >to decrease usage of the 8254 PIT on modern platforms, which solves a >real problem (see "x86: skip PIT initialization on modern chipsets"), >but I'd conservatively recommend just leaving these patches out of the >stable tree. The problem has existed for a while without a >particularly wide impact, and there is a somewhat documented >workaround of changing BIOS settings. I've dropped it, thanks! -- Thanks, Sasha