From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F65C7618B for ; Thu, 25 Jul 2019 05:50:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A70B820657 for ; Thu, 25 Jul 2019 05:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564033823; bh=BXbGsXOa9VO8OWmm5pyho2tcOhg7BywU2TkvD1p7kPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b9fgPr+2IomiVe5+//Qqg5IoNifcwXfxKREIZbo9E+dAsl1c5W9/DegrQwIkeIw0o owvJK9hUUwvDfY+WRu/bbOS4auCHRzi1m9aPw9d7xjT+TTg/oSBiLUfWAVGvXFfg8N NMX0a3J2wiX61wzO9crBb7YKqLHx6NXgX11XEIgA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390987AbfGYFnC (ORCPT ); Thu, 25 Jul 2019 01:43:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:57994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390984AbfGYFnB (ORCPT ); Thu, 25 Jul 2019 01:43:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC94F21850; Thu, 25 Jul 2019 05:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564033381; bh=BXbGsXOa9VO8OWmm5pyho2tcOhg7BywU2TkvD1p7kPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WJWmQpFs+l9IWFSmHy0I1fsbCWDB94TurRUDL725SxNnMRZ2qTsqojgxYaxHMTzLH qTgqygAO/1Kr88OiRFe+ae/CuimzvOrAaFbJPQI3rEUzQvkxq9Fw/afa9A2e2SIeqX ARo2EdGHIOGUunA7KGWnGQKUG/CIxveMkZKiQySI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Coly Li , Jens Axboe Subject: [PATCH 4.19 188/271] bcache: destroy dc->writeback_write_wq if failed to create dc->writeback_thread Date: Wed, 24 Jul 2019 21:20:57 +0200 Message-Id: <20190724191711.234053950@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191655.268628197@linuxfoundation.org> References: <20190724191655.268628197@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Coly Li commit f54d801dda14942dbefa00541d10603015b7859c upstream. Commit 9baf30972b55 ("bcache: fix for gc and write-back race") added a new work queue dc->writeback_write_wq, but forgot to destroy it in the error condition when creating dc->writeback_thread failed. This patch destroys dc->writeback_write_wq if kthread_create() returns error pointer to dc->writeback_thread, then a memory leak is avoided. Fixes: 9baf30972b55 ("bcache: fix for gc and write-back race") Signed-off-by: Coly Li Cc: stable@vger.kernel.org Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- drivers/md/bcache/writeback.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/md/bcache/writeback.c +++ b/drivers/md/bcache/writeback.c @@ -807,6 +807,7 @@ int bch_cached_dev_writeback_start(struc "bcache_writeback"); if (IS_ERR(dc->writeback_thread)) { cached_dev_put(dc); + destroy_workqueue(dc->writeback_write_wq); return PTR_ERR(dc->writeback_thread); }