From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DATE_IN_PAST_06_12, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE158C7618B for ; Thu, 25 Jul 2019 05:49:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8FCD2147A for ; Thu, 25 Jul 2019 05:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564033765; bh=AqHiGBYn3HleXsZMlRknDwFCCAMU0XQioeXh1aikw0Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=an9SfvlNmmoHwoI+q3TGl8ijFsUbBPr3xNVWfOtubnHj0kwYGX9ZFNhgFpAHm+t6B couclEPSYd/OrDf2qNhhp3LoRGtOz8c4l0QaoqybcRQUCDHJQxZIpJmXe0PZex6vdK vxYujMzAorc6Fi4fMvhEn265NLjQl/ZhVx3FoUlo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391258AbfGYFo0 (ORCPT ); Thu, 25 Jul 2019 01:44:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:59538 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391253AbfGYFoZ (ORCPT ); Thu, 25 Jul 2019 01:44:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64A6922BF5; Thu, 25 Jul 2019 05:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564033464; bh=AqHiGBYn3HleXsZMlRknDwFCCAMU0XQioeXh1aikw0Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W+tHN0OYoeQ/COtqsP5NV5jXluXvpIur1JliTgCrJUw45qaK8Pf3SQouL1T5hdxPe ON12kefUdrzhH0htONc4UY1VzbDBNQAx/ZjqNFdSig9k8g+A1toH6m8fJhUU6zllHK OSA3DkmVPSzDrgNZvyfPV15ue0c7j1gvvrzIGtD4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Philipp Zabel , Ezequiel Garcia , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.19 210/271] media: coda: Remove unbalanced and unneeded mutex unlock Date: Wed, 24 Jul 2019 21:21:19 +0200 Message-Id: <20190724191713.071665484@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191655.268628197@linuxfoundation.org> References: <20190724191655.268628197@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Ezequiel Garcia commit 766b9b168f6c75c350dd87c3e0bc6a9b322f0013 upstream. The mutex unlock in the threaded interrupt handler is not paired with any mutex lock. Remove it. This bug has been here for a really long time, so it applies to any stable repo. Reviewed-by: Philipp Zabel Signed-off-by: Ezequiel Garcia Signed-off-by: Hans Verkuil Cc: stable@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/coda/coda-bit.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/media/platform/coda/coda-bit.c +++ b/drivers/media/platform/coda/coda-bit.c @@ -2309,7 +2309,6 @@ irqreturn_t coda_irq_handler(int irq, vo if (ctx == NULL) { v4l2_err(&dev->v4l2_dev, "Instance released before the end of transaction\n"); - mutex_unlock(&dev->coda_mutex); return IRQ_HANDLED; }