From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0821C7618F for ; Wed, 24 Jul 2019 20:22:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3D0B2081B for ; Wed, 24 Jul 2019 20:22:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563999745; bh=FoaA1YC+rRTjrO05a9bfwU/h/RW7sujYxE3/nZVSiGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CLkySUf8engD3tFY8Q4UQZG68NtD+DRCgvrgYk+tmCUP/TMqr0LajkOwPhNmWRI+y 7e+D7UwCUZ/uw9OTO+IztjKyH7ikJ7uyMHWo9nFnrFbWs9NIAeazcV8YSQitrkisin W73xNvbiqC1leWtUs8OpQ7934mv3BG45gEiXwAyk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390287AbfGXTn4 (ORCPT ); Wed, 24 Jul 2019 15:43:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:46486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388211AbfGXTnz (ORCPT ); Wed, 24 Jul 2019 15:43:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F42F21873; Wed, 24 Jul 2019 19:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563997434; bh=FoaA1YC+rRTjrO05a9bfwU/h/RW7sujYxE3/nZVSiGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gCm72RxDyg5EWNHu7pn7J+14uVVnlopyTOFF6Ib8w2a4T912FiWoEDPKpgx9TrVQw SBjgmVN7CNsvXEmfXbyA6owE65+hFW3Nvg6Q7SxTxVLOMuDcBe7zoPKXzDq+galOjP SX0qAGpFJNCmCrd8vgLpHcddr5ujD+p4yyigv1ug= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+d454a826e670502484b8@syzkaller.appspotmail.com, Jeremy Sowden , Sven Eckelmann , Simon Wunderlich , Sasha Levin Subject: [PATCH 5.1 022/371] batman-adv: fix for leaked TVLV handler. Date: Wed, 24 Jul 2019 21:16:14 +0200 Message-Id: <20190724191726.164673947@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191724.382593077@linuxfoundation.org> References: <20190724191724.382593077@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 17f78dd1bd624a4dd78ed5db3284a63ee807fcc3 ] A handler for BATADV_TVLV_ROAM was being registered when the translation-table was initialized, but not unregistered when the translation-table was freed. Unregister it. Fixes: 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to use tvlv unicast packets") Reported-by: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com Signed-off-by: Jeremy Sowden Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich Signed-off-by: Sasha Levin --- net/batman-adv/translation-table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 26c4e2493ddf..abad64eb7dc4 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -3826,6 +3826,8 @@ static void batadv_tt_purge(struct work_struct *work) */ void batadv_tt_free(struct batadv_priv *bat_priv) { + batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_ROAM, 1); + batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_TT, 1); batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_TT, 1); -- 2.20.1