From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A3C4C7618F for ; Wed, 24 Jul 2019 20:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 266F720665 for ; Wed, 24 Jul 2019 20:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563999349; bh=XmCRhcluBrgdEiU7UeiEbvGV8BMAeUoxjrvsNuNatGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hU8N4MFVINC8gA84GBepmfsds3XJE/kzl2/InHUeeKkIX7qSHAlpZDfQZrYxr+mNx 8VysmprcLkZ44+c57p/s793PnzZ4CpHx2VpnI0QMMhREhDPCYRneer5Z0Uanf19/Tc u7XpUjn5GlGipnEAkGCUpCJB2tM/hnGGvewfvQrM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391732AbfGXTw1 (ORCPT ); Wed, 24 Jul 2019 15:52:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:34280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391725AbfGXTw1 (ORCPT ); Wed, 24 Jul 2019 15:52:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4AC720665; Wed, 24 Jul 2019 19:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563997946; bh=XmCRhcluBrgdEiU7UeiEbvGV8BMAeUoxjrvsNuNatGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IOLbEmnCmIBjTdOiUYZ7fWAwamCMyLjq9IioOUWxL1YYt69cjS7aPzcB10JpQrPHA 19gm71y/I+KE12XESWXXRXZGhTSbzxdTDCMCRRvuc4BbD84sv2Dw3u5CZvMgGC5Ndq iF4Dq/phKGkb80EVjT6AmG3Wsugj5iqMe/Fi0SbY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrii Nakryiko , Magnus Karlsson , Yonghong Song , Daniel Borkmann , Sasha Levin Subject: [PATCH 5.1 196/371] libbpf: fix GCC8 warning for strncpy Date: Wed, 24 Jul 2019 21:19:08 +0200 Message-Id: <20190724191739.560671136@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191724.382593077@linuxfoundation.org> References: <20190724191724.382593077@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit cdfc7f888c2a355b01308e97c6df108f1c2b64e8 ] GCC8 started emitting warning about using strncpy with number of bytes exactly equal destination size, which is generally unsafe, as can lead to non-zero terminated string being copied. Use IFNAMSIZ - 1 as number of bytes to ensure name is always zero-terminated. Signed-off-by: Andrii Nakryiko Cc: Magnus Karlsson Acked-by: Yonghong Song Acked-by: Magnus Karlsson Signed-off-by: Daniel Borkmann Signed-off-by: Sasha Levin --- tools/lib/bpf/xsk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c index af5f310ecca1..1fe0e1eec738 100644 --- a/tools/lib/bpf/xsk.c +++ b/tools/lib/bpf/xsk.c @@ -336,7 +336,8 @@ static int xsk_get_max_queues(struct xsk_socket *xsk) channels.cmd = ETHTOOL_GCHANNELS; ifr.ifr_data = (void *)&channels; - strncpy(ifr.ifr_name, xsk->ifname, IFNAMSIZ); + strncpy(ifr.ifr_name, xsk->ifname, IFNAMSIZ - 1); + ifr.ifr_name[IFNAMSIZ - 1] = '\0'; err = ioctl(fd, SIOCETHTOOL, &ifr); if (err && errno != EOPNOTSUPP) { ret = -errno; -- 2.20.1