From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C8CC76186 for ; Wed, 24 Jul 2019 19:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47B2321873 for ; Wed, 24 Jul 2019 19:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563998241; bh=AWiRpDhUWe3D66QtUkg0pgkGRfMqsc9N6RztAG8uWYY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=a80JkU32UULlzTg/moZXVJPOo3FH5sky+IS9UD5k//1rWOWo6/P0J79heSgECnSzz /bPHl+PDGEOwSXPNxhmvubz1t3FRtq8lF4u/J8v/VoIYhk9afkxLCX/YyTI3sKmt7C lwpbSjEthOImjTeo2uvGn4d1Qry/plqjMdq3cSWQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390603AbfGXT5U (ORCPT ); Wed, 24 Jul 2019 15:57:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:42542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404919AbfGXT5U (ORCPT ); Wed, 24 Jul 2019 15:57:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB5FE205C9; Wed, 24 Jul 2019 19:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563998239; bh=AWiRpDhUWe3D66QtUkg0pgkGRfMqsc9N6RztAG8uWYY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pynl8u9KDEIbTq2Cakdp64AhNcZwRMVVGGdVwD+9iWfh8V4FeQ64DrDSWl6lnwlSs XhKTlPhE0zLZoDxKCqOngdcf08/K7sMwbuzDDxBanpO7C4eb66xTOaSUKQmKwbgExM 1RYGah48K3dawGooqgLDwy1e/PR8rugXD1azmMc0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luis Henriques , Jeff Layton , Ilya Dryomov Subject: [PATCH 5.1 293/371] ceph: fix end offset in truncate_inode_pages_range call Date: Wed, 24 Jul 2019 21:20:45 +0200 Message-Id: <20190724191746.403605494@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191724.382593077@linuxfoundation.org> References: <20190724191724.382593077@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Luis Henriques commit d31d07b97a5e76f41e00eb81dcca740e84aa7782 upstream. Commit e450f4d1a5d6 ("ceph: pass inclusive lend parameter to filemap_write_and_wait_range()") fixed the end offset parameter used to call filemap_write_and_wait_range and invalidate_inode_pages2_range. Unfortunately it missed truncate_inode_pages_range, introducing a regression that is easily detected by xfstest generic/130. The problem is that when doing direct IO it is possible that an extra page is truncated from the page cache when the end offset is page aligned. This can cause data loss if that page hasn't been sync'ed to the OSDs. While there, change code to use PAGE_ALIGN macro instead. Cc: stable@vger.kernel.org Fixes: e450f4d1a5d6 ("ceph: pass inclusive lend parameter to filemap_write_and_wait_range()") Signed-off-by: Luis Henriques Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1006,7 +1006,7 @@ ceph_direct_read_write(struct kiocb *ioc * may block. */ truncate_inode_pages_range(inode->i_mapping, pos, - (pos+len) | (PAGE_SIZE - 1)); + PAGE_ALIGN(pos + len) - 1); req->r_mtime = mtime; }