From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7E3C76190 for ; Fri, 26 Jul 2019 13:42:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB11F22CD0 for ; Fri, 26 Jul 2019 13:42:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564148557; bh=tMWBYOgHAYiabn1YxSYJyUimcMhUZiXrErtPGmlTdWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VSKcmd3gCh0Hbl/HBLBpfCy7t07HyzCnnJqy48JO14TsUuxe43KNBhyOU0glkohfW Z6d9ZhYzrJivs/8eqt0MyAW3tmMNqAFtuJ/Y3KPUSupnKCZ0YPzv/rZUwuZbmRCEGl IduWjV4jZBLOJ6+lHaqKDuGmtEAAHj+yVATGfXWI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387980AbfGZNmg (ORCPT ); Fri, 26 Jul 2019 09:42:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:49884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387978AbfGZNmf (ORCPT ); Fri, 26 Jul 2019 09:42:35 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DD0322CD3; Fri, 26 Jul 2019 13:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564148554; bh=tMWBYOgHAYiabn1YxSYJyUimcMhUZiXrErtPGmlTdWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ijS9I7GxLxzVsCGekPClyOCKZZXtwAhx4cvlMhSg+kqi648OSdXQY6yATosBbYZ/R k3Im4T9IETJhVu6hQlDTJageuRX146M1h3PYg98pTTNrMMzfLCG1Ll9PpIGf5YswIo UTBsUjhq6m9Y/V+F29SGLQmMr4k/OkdC7G7TnXt0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Russell King , Al Viro , Sasha Levin Subject: [PATCH AUTOSEL 4.19 13/47] fs/adfs: super: fix use-after-free bug Date: Fri, 26 Jul 2019 09:41:36 -0400 Message-Id: <20190726134210.12156-13-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190726134210.12156-1-sashal@kernel.org> References: <20190726134210.12156-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Russell King [ Upstream commit 5808b14a1f52554de612fee85ef517199855e310 ] Fix a use-after-free bug during filesystem initialisation, where we access the disc record (which is stored in a buffer) after we have released the buffer. Signed-off-by: Russell King Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/adfs/super.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/adfs/super.c b/fs/adfs/super.c index 7e099a7a4eb1..4dc15b263489 100644 --- a/fs/adfs/super.c +++ b/fs/adfs/super.c @@ -369,6 +369,7 @@ static int adfs_fill_super(struct super_block *sb, void *data, int silent) struct buffer_head *bh; struct object_info root_obj; unsigned char *b_data; + unsigned int blocksize; struct adfs_sb_info *asb; struct inode *root; int ret = -EINVAL; @@ -420,8 +421,10 @@ static int adfs_fill_super(struct super_block *sb, void *data, int silent) goto error_free_bh; } + blocksize = 1 << dr->log2secsize; brelse(bh); - if (sb_set_blocksize(sb, 1 << dr->log2secsize)) { + + if (sb_set_blocksize(sb, blocksize)) { bh = sb_bread(sb, ADFS_DISCRECORD / sb->s_blocksize); if (!bh) { adfs_error(sb, "couldn't read superblock on " -- 2.20.1