stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.9 01/30] ARM: riscpc: fix DMA
Date: Fri, 26 Jul 2019 09:44:03 -0400	[thread overview]
Message-ID: <20190726134432.12993-1-sashal@kernel.org> (raw)

From: Russell King <rmk+kernel@armlinux.org.uk>

[ Upstream commit ffd9a1ba9fdb7f2bd1d1ad9b9243d34e96756ba2 ]

DMA got broken a while back in two different ways:
1) a change in the behaviour of disable_irq() to wait for the interrupt
   to finish executing causes us to deadlock at the end of DMA.
2) a change to avoid modifying the scatterlist left the first transfer
   uninitialised.

DMA is only used with expansion cards, so has gone unnoticed.

Fixes: fa4e99899932 ("[ARM] dma: RiscPC: don't modify DMA SG entries")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/arm/mach-rpc/dma.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-rpc/dma.c b/arch/arm/mach-rpc/dma.c
index 6d3517dc4772..82aac38fa2cf 100644
--- a/arch/arm/mach-rpc/dma.c
+++ b/arch/arm/mach-rpc/dma.c
@@ -131,7 +131,7 @@ static irqreturn_t iomd_dma_handle(int irq, void *dev_id)
 	} while (1);
 
 	idma->state = ~DMA_ST_AB;
-	disable_irq(irq);
+	disable_irq_nosync(irq);
 
 	return IRQ_HANDLED;
 }
@@ -174,6 +174,9 @@ static void iomd_enable_dma(unsigned int chan, dma_t *dma)
 				DMA_FROM_DEVICE : DMA_TO_DEVICE);
 		}
 
+		idma->dma_addr = idma->dma.sg->dma_address;
+		idma->dma_len = idma->dma.sg->length;
+
 		iomd_writeb(DMA_CR_C, dma_base + CR);
 		idma->state = DMA_ST_AB;
 	}
-- 
2.20.1


             reply	other threads:[~2019-07-26 13:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26 13:44 Sasha Levin [this message]
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 02/30] ARM: dts: rockchip: Make rk3288-veyron-minnie run at hs200 Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 03/30] ARM: dts: rockchip: Make rk3288-veyron-mickey's emmc work again Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 04/30] ARM: dts: rockchip: Mark that the rk3288 timer might stop in suspend Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 05/30] ftrace: Enable trampoline when rec count returns back to one Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 06/30] kernel/module.c: Only return -EEXIST for modules that have finished loading Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 07/30] MIPS: lantiq: Fix bitfield masking Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 08/30] dmaengine: rcar-dmac: Reject zero-length slave DMA requests Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 09/30] fs/adfs: super: fix use-after-free bug Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 10/30] btrfs: fix minimum number of chunk errors for DUP Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 11/30] ceph: fix improper use of smp_mb__before_atomic() Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 12/30] ceph: return -ERANGE if virtual xattr value didn't fit in buffer Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 13/30] scsi: zfcp: fix GCC compiler warning emitted with -Wmaybe-uninitialized Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 14/30] ACPI: fix false-positive -Wuninitialized warning Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 15/30] ISDN: hfcsusb: checking idx of ep configuration Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 16/30] be2net: Signal that the device cannot transmit during reconfiguration Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 17/30] x86/apic: Silence -Wtype-limits compiler warnings Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 18/30] x86: math-emu: Hide clang warnings for 16-bit overflow Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 19/30] mm/cma.c: fail if fixed declaration can't be honored Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 20/30] coda: add error handling for fget Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 21/30] coda: fix build using bare-metal toolchain Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 22/30] uapi linux/coda_psdev.h: move upc_req definition from uapi to kernel side headers Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 23/30] drivers/rapidio/devices/rio_mport_cdev.c: NUL terminate some strings Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 24/30] drivers/pps/pps.c: clear offset flags in PPS_SETPARAMS ioctl Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 25/30] ipc/mqueue.c: only perform resource calculation if user valid Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 26/30] floppy: fix div-by-zero in setup_format_params Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 27/30] floppy: fix out-of-bounds read in copy_buffer Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 28/30] xen: let alloc_xenballooned_pages() fail if not enough memory free Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 29/30] x86/kvm: Don't call kvm_spurious_fault() from .fixup Sasha Levin
2019-07-26 13:44 ` [PATCH AUTOSEL 4.9 30/30] x86, boot: Remove multiple copy of static function sanitize_boot_params() Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190726134432.12993-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).