stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Petr Cvek <petrcvekcz@gmail.com>,
	Paul Burton <paul.burton@mips.com>,
	hauke@hauke-m.de, john@phrozen.org, linux-mips@vger.kernel.org,
	openwrt-devel@lists.openwrt.org, pakahmar@hotmail.com,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.4 04/23] MIPS: lantiq: Fix bitfield masking
Date: Fri, 26 Jul 2019 09:45:03 -0400	[thread overview]
Message-ID: <20190726134522.13308-4-sashal@kernel.org> (raw)
In-Reply-To: <20190726134522.13308-1-sashal@kernel.org>

From: Petr Cvek <petrcvekcz@gmail.com>

[ Upstream commit ba1bc0fcdeaf3bf583c1517bd2e3e29cf223c969 ]

The modification of EXIN register doesn't clean the bitfield before
the writing of a new value. After a few modifications the bitfield would
accumulate only '1's.

Signed-off-by: Petr Cvek <petrcvekcz@gmail.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: hauke@hauke-m.de
Cc: john@phrozen.org
Cc: linux-mips@vger.kernel.org
Cc: openwrt-devel@lists.openwrt.org
Cc: pakahmar@hotmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 arch/mips/lantiq/irq.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
index 2e7f60c9fc5d..a7057a06c096 100644
--- a/arch/mips/lantiq/irq.c
+++ b/arch/mips/lantiq/irq.c
@@ -160,8 +160,9 @@ static int ltq_eiu_settype(struct irq_data *d, unsigned int type)
 			if (edge)
 				irq_set_handler(d->hwirq, handle_edge_irq);
 
-			ltq_eiu_w32(ltq_eiu_r32(LTQ_EIU_EXIN_C) |
-				(val << (i * 4)), LTQ_EIU_EXIN_C);
+			ltq_eiu_w32((ltq_eiu_r32(LTQ_EIU_EXIN_C) &
+				    (~(7 << (i * 4)))) | (val << (i * 4)),
+				    LTQ_EIU_EXIN_C);
 		}
 	}
 
-- 
2.20.1


  parent reply	other threads:[~2019-07-26 13:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26 13:45 [PATCH AUTOSEL 4.4 01/23] ARM: riscpc: fix DMA Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 02/23] ARM: dts: rockchip: Mark that the rk3288 timer might stop in suspend Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 03/23] kernel/module.c: Only return -EEXIST for modules that have finished loading Sasha Levin
2019-07-26 13:45 ` Sasha Levin [this message]
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 05/23] dmaengine: rcar-dmac: Reject zero-length slave DMA requests Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 06/23] fs/adfs: super: fix use-after-free bug Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 07/23] btrfs: fix minimum number of chunk errors for DUP Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 08/23] ceph: fix improper use of smp_mb__before_atomic() Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 09/23] scsi: zfcp: fix GCC compiler warning emitted with -Wmaybe-uninitialized Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 10/23] ACPI: fix false-positive -Wuninitialized warning Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 11/23] ISDN: hfcsusb: checking idx of ep configuration Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 12/23] be2net: Signal that the device cannot transmit during reconfiguration Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 13/23] x86/apic: Silence -Wtype-limits compiler warnings Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 14/23] x86: math-emu: Hide clang warnings for 16-bit overflow Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 15/23] mm/cma.c: fail if fixed declaration can't be honored Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 16/23] coda: add error handling for fget Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 17/23] coda: fix build using bare-metal toolchain Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 18/23] uapi linux/coda_psdev.h: move upc_req definition from uapi to kernel side headers Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 19/23] drivers/pps/pps.c: clear offset flags in PPS_SETPARAMS ioctl Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 20/23] ipc/mqueue.c: only perform resource calculation if user valid Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 21/23] floppy: fix div-by-zero in setup_format_params Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 22/23] floppy: fix out-of-bounds read in copy_buffer Sasha Levin
2019-07-26 13:45 ` [PATCH AUTOSEL 4.4 23/23] x86/kvm: Don't call kvm_spurious_fault() from .fixup Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190726134522.13308-4-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=john@phrozen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=openwrt-devel@lists.openwrt.org \
    --cc=pakahmar@hotmail.com \
    --cc=paul.burton@mips.com \
    --cc=petrcvekcz@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).