From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3289CC7618B for ; Fri, 26 Jul 2019 15:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07F8421951 for ; Fri, 26 Jul 2019 15:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564155590; bh=1HpdXPdCH3AGliimYDa8ivFia1SmaPzjNwsuVwn7LSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nUPcvY9AQ1HD+jbfA1U09kkM4QkfL4KlA0Q72XDfTRi3f37XH2mXH3OPbLgkUd7YG 32B5frIcxzhWuXd825ztlVnTWYr5S3YpUCG0t/qq0jOgJ67/4CGd7FOUG5/gbNdxiP FEUUWt7cNc6Xz505dzliRutcHAU31ZZ6A2g32MUA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387935AbfGZPjl (ORCPT ); Fri, 26 Jul 2019 11:39:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:39490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727985AbfGZPZl (ORCPT ); Fri, 26 Jul 2019 11:25:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC062218D4; Fri, 26 Jul 2019 15:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564154740; bh=1HpdXPdCH3AGliimYDa8ivFia1SmaPzjNwsuVwn7LSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RMeJ2QhS4p+CGzyN/tbpLlaFeuoCdpmxI4X4AtPvLuJ6becvQT7uTJljivBMaBZ2y S9nt1BonZSNQVwkMiFNKyzESc38bWBCdV37V0z6QDsn8+jO61AW5UTtHE6BTNRAtMK 1spgqzc+OHJiAx7IuaXkClEF0J5zYaaMegWcvzGw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haiyang Zhang , "David S. Miller" Subject: [PATCH 5.2 03/66] hv_netvsc: Fix extra rcu_read_unlock in netvsc_recv_callback() Date: Fri, 26 Jul 2019 17:24:02 +0200 Message-Id: <20190726152302.308798082@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190726152301.936055394@linuxfoundation.org> References: <20190726152301.936055394@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Haiyang Zhang [ Upstream commit be4363bdf0ce9530f15aa0a03d1060304d116b15 ] There is an extra rcu_read_unlock left in netvsc_recv_callback(), after a previous patch that removes RCU from this function. This patch removes the extra RCU unlock. Fixes: 345ac08990b8 ("hv_netvsc: pass netvsc_device to receive callback") Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/hyperv/netvsc_drv.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -836,7 +836,6 @@ int netvsc_recv_callback(struct net_devi if (unlikely(!skb)) { ++net_device_ctx->eth_stats.rx_no_memory; - rcu_read_unlock(); return NVSP_STAT_FAIL; }