From: Greg KH <gregkh@linuxfoundation.org>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH 3/8] drm/i915/userptr: Acquire the page lock around set_page_dirty()
Date: Mon, 29 Jul 2019 19:49:42 +0200 [thread overview]
Message-ID: <20190729174942.GC19326@kroah.com> (raw)
In-Reply-To: <20190726073556.9011-4-joonas.lahtinen@linux.intel.com>
On Fri, Jul 26, 2019 at 10:35:51AM +0300, Joonas Lahtinen wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> set_page_dirty says:
>
> For pages with a mapping this should be done under the page lock
> for the benefit of asynchronous memory errors who prefer a
> consistent dirty state. This rule can be broken in some special
> cases, but should be better not to.
>
> Under those rules, it is only safe for us to use the plain set_page_dirty
> calls for shmemfs/anonymous memory. Userptr may be used with real
> mappings and so needs to use the locked version (set_page_dirty_lock).
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203317
> Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl")
> References: 6dcc693bc57f ("ext4: warn when page is dirtied without buffers")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: stable@vger.kernel.org
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20190708140327.26825-1-chris@chris-wilson.co.uk
> (cherry picked from commit cb6d7c7dc7ff8cace666ddec66334117a6068ce2)
This commit id is not in Linus's tree.
I've stopped here, and dropped patch 1/8 as well. Please fix these all
up to have the correct git ids and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2019-07-29 17:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 7:35 [PATCH 0/8] i915 fixes that missed v5.2 Joonas Lahtinen
2019-07-26 7:35 ` [PATCH 1/8] drm/i915: Make the semaphore saturation mask global Joonas Lahtinen
2019-07-26 7:35 ` [PATCH 2/8] drm/i915/perf: fix ICL perf register offsets Joonas Lahtinen
2019-07-29 17:49 ` Greg KH
2019-07-26 7:35 ` [PATCH 3/8] drm/i915/userptr: Acquire the page lock around set_page_dirty() Joonas Lahtinen
2019-07-29 17:49 ` Greg KH [this message]
2019-08-02 9:21 ` Joonas Lahtinen
2019-07-26 7:35 ` [PATCH 4/8] drm/i915: Disable SAMPLER_STATE prefetching on all Gen11 steppings Joonas Lahtinen
2019-07-26 7:35 ` [PATCH 5/8] drm/i915: Support flags in whitlist WAs Joonas Lahtinen
2019-07-26 7:35 ` [PATCH 6/8] drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT Joonas Lahtinen
2019-07-26 7:35 ` [PATCH 7/8] drm/i915/icl: " Joonas Lahtinen
2019-07-26 7:35 ` [PATCH 8/8] drm/i915: Don't dereference request if it may have been retired when printing Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729174942.GC19326@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).