From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E8FC41514 for ; Mon, 29 Jul 2019 19:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03D90217D7 for ; Mon, 29 Jul 2019 19:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428484; bh=V7IVo0iwIu+sC7gWTWTEMn7Gmx6aLqUCMxmrNGlIN2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EOSJdvgbdLQsoPqrwlySrLsBXuKm0MuXSV1x5V2SdXSyyC3Cy3eYB19ibiKSgc+mu xpMZYlvV+y24Z/FRxueEjmrH+oV6DXlSWl531u8UYVLhhaJrvUz0kaJBOfHDfkSkc7 c66qZnz/q1PPknzA2B9NmhWD1mIvKVTELoHlTtE4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729963AbfG2T2D (ORCPT ); Mon, 29 Jul 2019 15:28:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:40724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727628AbfG2T2C (ORCPT ); Mon, 29 Jul 2019 15:28:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DC8221773; Mon, 29 Jul 2019 19:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428481; bh=V7IVo0iwIu+sC7gWTWTEMn7Gmx6aLqUCMxmrNGlIN2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dxgIawUZhtBIzDq7tMOvkYSu1SmxvBUu4U5d7qN8MwCkLsowUsIcIThmlQE/Q2Fra 5wS1N1D/7nJRIneZyfuO/V9PuN8v5MedhEm+luxdIOlJgfk1nJXQB6LPbkFcXJxaWm 3JU2SaMcnwiSLdxxfXjA6ZYqItLEzjUqPTwzfjHY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yonglong Liu , Peng Li , Huazhong Tan , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 089/293] net: hns3: fix a -Wformat-nonliteral compile warning Date: Mon, 29 Jul 2019 21:19:40 +0200 Message-Id: <20190729190831.412957231@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 18d219b783da61a6cc77581f55fc4af2fa16bc36 ] When setting -Wformat=2, there is a compiler warning like this: hclge_main.c:xxx:x: warning: format not a string literal and no format arguments [-Wformat-nonliteral] strs[i].desc); ^~~~ This patch adds missing format parameter "%s" to snprintf() to fix it. Fixes: 46a3df9f9718 ("Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index 654aad6e748b..86523e8993cb 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -619,8 +619,7 @@ static u8 *hclge_comm_get_strings(u32 stringset, return buff; for (i = 0; i < size; i++) { - snprintf(buff, ETH_GSTRING_LEN, - strs[i].desc); + snprintf(buff, ETH_GSTRING_LEN, "%s", strs[i].desc); buff = buff + ETH_GSTRING_LEN; } -- 2.20.1