From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFF4C433FF for ; Mon, 29 Jul 2019 20:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73E382064C for ; Mon, 29 Jul 2019 20:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564431100; bh=B+4mkE2wlLtHn+8VNj1PDnu0y6OxojTs8LQSdPTpCJQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=O3idMIJmCyj9eE+Dm6VaqkQGSed1diyjQqb9LJpnxhFztuUPt5OrDJ3Gj4liZEvGm 6ivzjEmeNm1Kc/Af8njIedCAApsWaH4Q2jFCizF7LUN10eXQ4Gc+PS0ZpenvoitAGz fdAKDAKWZ+lgLQcIS5ovLmPpDdPiXlDyJMlQFdGY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729556AbfG2TdI (ORCPT ); Mon, 29 Jul 2019 15:33:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:46976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729778AbfG2TdF (ORCPT ); Mon, 29 Jul 2019 15:33:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61D1121655; Mon, 29 Jul 2019 19:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564428784; bh=B+4mkE2wlLtHn+8VNj1PDnu0y6OxojTs8LQSdPTpCJQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dnLKPoxN++RUxCUSug+lzx0X3+OmmvzlVZyGVxFwys/oX5S9sG++lxOQyKGTs8kXJ u1XgIGmSOzoySyi90D7ugcIca3yF2uP0WP9mOPCQKnFLesFEK5RJB0ee7tp1j87AwA jCkz+vVzAjzxZ4Mre2aSbfFgtpMT4DsT6lz2Ik54= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Taehee Yoo , "David S. Miller" Subject: [PATCH 4.14 183/293] caif-hsi: fix possible deadlock in cfhsi_exit_module() Date: Mon, 29 Jul 2019 21:21:14 +0200 Message-Id: <20190729190838.522437823@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190729190820.321094988@linuxfoundation.org> References: <20190729190820.321094988@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Taehee Yoo [ Upstream commit fdd258d49e88a9e0b49ef04a506a796f1c768a8e ] cfhsi_exit_module() calls unregister_netdev() under rtnl_lock(). but unregister_netdev() internally calls rtnl_lock(). So deadlock would occur. Fixes: c41254006377 ("caif-hsi: Add rtnl support") Signed-off-by: Taehee Yoo Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/caif/caif_hsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/caif/caif_hsi.c +++ b/drivers/net/caif/caif_hsi.c @@ -1462,7 +1462,7 @@ static void __exit cfhsi_exit_module(voi rtnl_lock(); list_for_each_safe(list_node, n, &cfhsi_list) { cfhsi = list_entry(list_node, struct cfhsi, list); - unregister_netdev(cfhsi->ndev); + unregister_netdevice(cfhsi->ndev); } rtnl_unlock(); }