From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33996C32750 for ; Fri, 2 Aug 2019 09:37:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A49520B7C for ; Fri, 2 Aug 2019 09:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564738663; bh=JvLdXu7j141+TLLTbqz/wW4nRv2BmpL+czVTejfmUKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hqfy8OA5lULsQuIlss2KHChZTzNudY0yYGUJ88oQb91937Hgc6JSgpdokGU2e92lQ w8VJgjPxelSHfZU1IhCBY9Cbd9bZnpn8X66p66yy6cyNXZeIhcCVrJppHNxTA6Dku0 j65V1EbxznaNfW3DjjFevyQoHcURoCRU8WAf+VLk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391697AbfHBJfj (ORCPT ); Fri, 2 Aug 2019 05:35:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:36240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731210AbfHBJfi (ORCPT ); Fri, 2 Aug 2019 05:35:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FB412184D; Fri, 2 Aug 2019 09:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564738537; bh=JvLdXu7j141+TLLTbqz/wW4nRv2BmpL+czVTejfmUKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1bITs253XKt/7VwfYceoyBklaRMzsU9EcXG0iua8QtwWANXHg++7/G3xAIp45OKlQ 8loRJIM4NG/GQDxEgTFEY9jtN1sMPJgGMaddeBBM6+bdNDj9g3pDKvW/a8BVAB38nb gY6Fch32TqvmmQLu965uNoaC8KzaeLKdf7SDGw8A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christian Lamparter , Michael Ellerman , Sasha Levin Subject: [PATCH 4.4 126/158] powerpc/4xx/uic: clear pending interrupt after irq type/pol change Date: Fri, 2 Aug 2019 11:29:07 +0200 Message-Id: <20190802092229.222140864@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190802092203.671944552@linuxfoundation.org> References: <20190802092203.671944552@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 3ab3a0689e74e6aa5b41360bc18861040ddef5b1 ] When testing out gpio-keys with a button, a spurious interrupt (and therefore a key press or release event) gets triggered as soon as the driver enables the irq line for the first time. This patch clears any potential bogus generated interrupt that was caused by the switching of the associated irq's type and polarity. Signed-off-by: Christian Lamparter Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/sysdev/uic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c index 6893d8f236df..225346dda151 100644 --- a/arch/powerpc/sysdev/uic.c +++ b/arch/powerpc/sysdev/uic.c @@ -158,6 +158,7 @@ static int uic_set_irq_type(struct irq_data *d, unsigned int flow_type) mtdcr(uic->dcrbase + UIC_PR, pr); mtdcr(uic->dcrbase + UIC_TR, tr); + mtdcr(uic->dcrbase + UIC_SR, ~mask); raw_spin_unlock_irqrestore(&uic->lock, flags); -- 2.20.1