From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3804C32753 for ; Fri, 2 Aug 2019 09:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD05F2087E for ; Fri, 2 Aug 2019 09:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564739525; bh=ur8nRVmVhP1WaR5+Nsi2TyNFb9kDDc3oWmRJ9xTVwME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=q6IVGiMgi6e4UbWM02ZXYastWnS2Iz26owNlQ7rXf+5QRxeH7j1uK2yK4b0qpqngZ HkenjRPvecMtvxg5gMXYzcW/2sFXD9LNCrBNfhf+T+vM3a/l7uqpI+x2nQypUq1+U7 +Y36a5SW0Tr49BFKWE02bTKM6x00zLpkNPDWYSZc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392155AbfHBJwE (ORCPT ); Fri, 2 Aug 2019 05:52:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:57512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392154AbfHBJwE (ORCPT ); Fri, 2 Aug 2019 05:52:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D662D206A2; Fri, 2 Aug 2019 09:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564739523; bh=ur8nRVmVhP1WaR5+Nsi2TyNFb9kDDc3oWmRJ9xTVwME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D+o9F8zqvACYP2Fzdfd57F4wBA9mMAOMumhVw9QNxXpgHv62Fad900TlmcY/DumlA ekZEb36YWSWbZX5lyVXfasyyejvWxLr2r5ZkbSfRYKJRr1FpmtsCZMJscZgbLNaXvH hJdsTliFj09N1aeu84GuXoZ+0xtnocmJhFIdSoTc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christian Lamparter , Michael Ellerman , Sasha Levin Subject: [PATCH 4.9 185/223] powerpc/4xx/uic: clear pending interrupt after irq type/pol change Date: Fri, 2 Aug 2019 11:36:50 +0200 Message-Id: <20190802092249.538706632@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190802092238.692035242@linuxfoundation.org> References: <20190802092238.692035242@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 3ab3a0689e74e6aa5b41360bc18861040ddef5b1 ] When testing out gpio-keys with a button, a spurious interrupt (and therefore a key press or release event) gets triggered as soon as the driver enables the irq line for the first time. This patch clears any potential bogus generated interrupt that was caused by the switching of the associated irq's type and polarity. Signed-off-by: Christian Lamparter Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/sysdev/uic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c index a00949f3e378..a8ebc96dfed2 100644 --- a/arch/powerpc/sysdev/uic.c +++ b/arch/powerpc/sysdev/uic.c @@ -158,6 +158,7 @@ static int uic_set_irq_type(struct irq_data *d, unsigned int flow_type) mtdcr(uic->dcrbase + UIC_PR, pr); mtdcr(uic->dcrbase + UIC_TR, tr); + mtdcr(uic->dcrbase + UIC_SR, ~mask); raw_spin_unlock_irqrestore(&uic->lock, flags); -- 2.20.1