From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B463C433FF for ; Fri, 2 Aug 2019 13:48:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E786B21726 for ; Fri, 2 Aug 2019 13:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564753711; bh=yrUhfboA+pxlwVQceH5hZCnB8tZ8n2uD14vFSNTwoFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VrVrEirD3jT0p8QTNzdtQsCQUfYX+vRuZYWqo7KqG8SuoUlE8ixAHoMs+rteChMVS ITEVw+/pi/6/MVpj6m4FRQiPbNw+sj2uz5DwEeXiZEpMopb4ljQfT7NONt4uZoREwH TW0y6/SuvHJ/1NcWk5UwSpOgaURYVdQ6jj+vcT/E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394837AbfHBNsa (ORCPT ); Fri, 2 Aug 2019 09:48:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:48674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730199AbfHBNsa (ORCPT ); Fri, 2 Aug 2019 09:48:30 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85CC920679; Fri, 2 Aug 2019 13:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564753709; bh=yrUhfboA+pxlwVQceH5hZCnB8tZ8n2uD14vFSNTwoFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0jGh3uFTyMfE0JevXIUjXo4dTNgOjHMJFiFePLYswMhTdzF9QdEKqdS/aNJBzOUlX LQThVc2endYLqXhXno2aXAGbqSV6Dg1GGHiusQNfuWVzT2D/JuCjZvlBrAgrhpwfqn VQ7Fkjdnj5z/Te0a6+I0MjMGqQkgnjBedsQCIJsE= Date: Fri, 2 Aug 2019 09:48:28 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+d952e5e28f5fb7718d23@syzkaller.appspotmail.com, Takashi Iwai Subject: Re: [PATCH 5.2 03/20] ALSA: usb-audio: Sanity checks for each pipe and EP types Message-ID: <20190802134828.GA797@sasha-vm> References: <20190802092055.131876977@linuxfoundation.org> <20190802092058.248343532@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190802092058.248343532@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Aug 02, 2019 at 11:39:57AM +0200, Greg Kroah-Hartman wrote: >From: Takashi Iwai > >commit 801ebf1043ae7b182588554cc9b9ad3c14bc2ab5 upstream. > >The recent USB core code performs sanity checks for the given pipe and >EP types, and it can be hit by manipulated USB descriptors by syzbot. >For making syzbot happier, this patch introduces a local helper for a >sanity check in the driver side and calls it at each place before the >message handling, so that we can avoid the WARNING splats. > >Reported-by: syzbot+d952e5e28f5fb7718d23@syzkaller.appspotmail.com >Signed-off-by: Takashi Iwai >Signed-off-by: Greg Kroah-Hartman This commit has a fix: 5d78e1c2b7f4b ("ALSA: usb-audio: Fix gpf in snd_usb_pipe_sanity_check") which was not pulled by Linus yet. I'm going to drop this commit and re-queue it together with it's fix once it makes it upstream. -- Thanks, Sasha