From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724D3C433FF for ; Fri, 2 Aug 2019 15:37:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B32221773 for ; Fri, 2 Aug 2019 15:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564760276; bh=J7foXkkyvGLjn2NR3WtZ/s3yoZlp3/yFLIuz0F/IbVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ScVAaJpUSriqQexk/i3RjnXp+laqRLpvwPvobCX3gz4ykbi2pKcmdzgv2HUuvHk30 OCh9zzQJPtbMoZJVAf6h7+7VIxi6Jp8j2zTp6OOmkNN/C0fCgI1RPWUqKhD1nb9ACS sdbQIBPuF6duN5TcOkAZMHulNWo1qLv/wVgGXGJ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726237AbfHBPhz (ORCPT ); Fri, 2 Aug 2019 11:37:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:36928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbfHBPhz (ORCPT ); Fri, 2 Aug 2019 11:37:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B1A120665; Fri, 2 Aug 2019 15:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564760274; bh=J7foXkkyvGLjn2NR3WtZ/s3yoZlp3/yFLIuz0F/IbVY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xfxfofhw0zX0VPEViOCDd+foY6VhBnyOdngK1y3/Yrawcp2Wnk7J5SALvURRNysep DSbmUwEvo7gex3StN5hvl+MubVV9rIytvDnvBj0GEK199ZlfaTtnwWgr3vBKaCvj7M nqoj3GyqEsa8McsL0qNd5qPfhFLBxOeM93tCKqgI= Date: Fri, 2 Aug 2019 17:37:51 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Jann Horn , "Peter Zijlstra (Intel)" , Linus Torvalds , Petr Mladek , Sergey Senozhatsky , Thomas Gleixner , Will Deacon , Ingo Molnar Subject: Re: [PATCH 4.14 25/25] sched/fair: Use RCU accessors consistently for ->numa_group Message-ID: <20190802153751.GA17602@kroah.com> References: <20190802092058.428079740@linuxfoundation.org> <20190802092107.912885585@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802092107.912885585@linuxfoundation.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Aug 02, 2019 at 11:39:57AM +0200, Greg Kroah-Hartman wrote: > From: Jann Horn > > commit cb361d8cdef69990f6b4504dc1fd9a594d983c97 upstream. > > The old code used RCU annotations and accessors inconsistently for > ->numa_group, which can lead to use-after-frees and NULL dereferences. > > Let all accesses to ->numa_group use proper RCU helpers to prevent such > issues. > > Signed-off-by: Jann Horn > Signed-off-by: Peter Zijlstra (Intel) > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Petr Mladek > Cc: Sergey Senozhatsky > Cc: Thomas Gleixner > Cc: Will Deacon > Fixes: 8c8a743c5087 ("sched/numa: Use {cpu, pid} to create task groups for shared faults") > Link: https://lkml.kernel.org/r/20190716152047.14424-3-jannh@google.com > Signed-off-by: Ingo Molnar > Signed-off-by: Greg Kroah-Hartman Oops, nope, this didn't apply, sorry about that, it needs to be properly backported to 4.14.y and older before it can go here. thanks, greg k-h