From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95CC6C433FF for ; Sat, 3 Aug 2019 07:11:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68B582166E for ; Sat, 3 Aug 2019 07:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564816264; bh=a+s3IKedwqS8VKGCh+ziLpXwsfOx5quqRxxkvqzATe8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NL8ZWJgJwYUUATyIXvfnvxW68uerHHoDUUoy1XRVMbVGWbZAEXzO6tszLkZ2ucF/s xEkZZkuIxewyrkb3NaQCcm4In0qMNdK8uT3yByhRRGAcr6YqwRJ3NTrucn2SQX6kVQ zHxCnNFaEnel5xYv0KRlauY5JjbR6slvNCRej7co= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727203AbfHCHLE (ORCPT ); Sat, 3 Aug 2019 03:11:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:42012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727206AbfHCHLD (ORCPT ); Sat, 3 Aug 2019 03:11:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC4BE2087C; Sat, 3 Aug 2019 07:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564816262; bh=a+s3IKedwqS8VKGCh+ziLpXwsfOx5quqRxxkvqzATe8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tAmbRij31rq13cBdzZU1k1kacry7T8PTK4bqZOnIpO6qXsqSbx14kjsXOle5uwtYO Vn5nZNvO+kn816Azrq0YfnqeoNvN/l4ScTUbT5XfGkSWQBwz4y4Vw2U5ZC73LeDKWc EsArYbK3dpAbIKcMJjFTWVckOShAN6bqGuxMrXAM= Date: Sat, 3 Aug 2019 09:11:00 +0200 From: "gregkh@linuxfoundation.org" To: Xin Long Cc: "Rantala, Tommi T. (Nokia - FI/Espoo)" , "davem@davemloft.net" , "syzbot+a43d8d4e7e8a7a9e149e@syzkaller.appspotmail.com" , "syzbot+c4c4b2bb358bb936ad7e@syzkaller.appspotmail.com" , "syzbot+a47c5f4c6c00fc1ed16e@syzkaller.appspotmail.com" , "syzbot+a9e23ea2aa21044c2798@syzkaller.appspotmail.com" , "linux-kernel@vger.kernel.org" , "syzbot+0290d2290a607e035ba1@syzkaller.appspotmail.com" , "stable@vger.kernel.org" , "syzbot+9d4c12bfd45a58738d0a@syzkaller.appspotmail.com" Subject: Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb Message-ID: <20190803071100.GC24334@kroah.com> References: <20190702080123.904399496@linuxfoundation.org> <20190702080126.138655706@linuxfoundation.org> <0f105a3696611dc10aa4d7c5c22ffac031b3c098.camel@nokia.com> <20190802072834.GC26174@kroah.com> <88c88ec44e93c07170891bdf391d2b6251c7041a.camel@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, Aug 03, 2019 at 08:45:03AM +0800, Xin Long wrote: > On Fri, Aug 2, 2019 at 7:03 PM Rantala, Tommi T. (Nokia - FI/Espoo) > wrote: > > > > On Fri, 2019-08-02 at 09:28 +0200, gregkh@linuxfoundation.org wrote: > > > On Thu, Aug 01, 2019 at 10:17:30AM +0000, Rantala, Tommi T. (Nokia - > > > FI/Espoo) wrote: > > > > Hi, > > > > > > > > This tipc patch added in 4.14.132 is triggering a crash for me, > > > > revert > > > > fixes it. > > > > > > > > Anyone have ideas if some other commits missing in 4.14.x to make > > > > this > > > > work...? > > > > > > Do you also hav a problem with 4.19.y? How about 5.2.y? If not, can > > > you do 'git bisect' to find the patch that fixes the issue? > > > > > > thanks, > > > > > > greg k-h > > > > Hi, please pick this to 4.14.y and 4.19.y, tested that it fixes the > > crash in both: > > > > commit 5684abf7020dfc5f0b6ba1d68eda3663871fce52 > > Author: Xin Long > > Date: Mon Jun 17 21:34:13 2019 +0800 > > > > ip_tunnel: allow not to count pkts on tstats by setting skb's dev > > to NULL > Thanks Rantala, > > sorry for late, I was in a trip. > > The patch belongs to a patchset: > > https://www.spinics.net/lists/netdev/msg578674.html > > So this commit should also be included: > > commit 6f6a8622057c92408930c31698394fae1557b188 > Author: Xin Long > Date: Mon Jun 17 21:34:14 2019 +0800 > > ip6_tunnel: allow not to count pkts on tstats by passing dev as NULL This commit is also included in the following kernel releases: 4.9.186 4.14.134 4.19.59 5.1.18 5.2 so this should all be taken care of, right? If not, please let me know. thanks, greg k-h