From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B32C4C0650F for ; Mon, 5 Aug 2019 13:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 870CF214C6 for ; Mon, 5 Aug 2019 13:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565011460; bh=cHBuQxWMxd+G4L/H7HVGgTx3wUtKf65ryer0WXRBYHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vy8hN9rAyxi1FDc4GH94wDRrW5Vd+gCQP7PUyzslfe4AMGJuNUdv3soh2LaFxVKc2 tcL+rS9QI4brXh6WLXI8gSfaZd8sgH7H3lT4+jv0g4RxX5atct8/wy0N8I1wPDWQu6 SD5pauqjXEGJ1Xr6tvGtOg2UZ+9hHnAvaDYZ1kg0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730970AbfHENYO (ORCPT ); Mon, 5 Aug 2019 09:24:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:60978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730947AbfHENYN (ORCPT ); Mon, 5 Aug 2019 09:24:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 648E32087B; Mon, 5 Aug 2019 13:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565011452; bh=cHBuQxWMxd+G4L/H7HVGgTx3wUtKf65ryer0WXRBYHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ojCHnC0cllJ80Bs4NVkzLEU2jEd/ci/bfLXvVZQZ4lZJsecNAaEUIwBjjZIByB54J hX9XzdDGCarfBwHIFHXIXsF2h74APHHPoJHs8s90s0/oiPsjiQY2ZQBIUiol0raGSF gKeAJnV2qkMlrZM6YWSFczYoYMtP6+d941TMIQDI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jean Delvare , Andrew Lunn , Srinivas Kandagatla , Bartosz Golaszewski , Arnd Bergmann , Bartosz Golaszewski Subject: [PATCH 5.2 093/131] eeprom: at24: make spd world-readable again Date: Mon, 5 Aug 2019 15:03:00 +0200 Message-Id: <20190805124958.193622253@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190805124951.453337465@linuxfoundation.org> References: <20190805124951.453337465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jean Delvare commit 25e5ef302c24a6fead369c0cfe88c073d7b97ca8 upstream. The integration of the at24 driver into the nvmem framework broke the world-readability of spd EEPROMs. Fix it. Signed-off-by: Jean Delvare Cc: stable@vger.kernel.org Fixes: 57d155506dd5 ("eeprom: at24: extend driver to plug into the NVMEM framework") Cc: Andrew Lunn Cc: Srinivas Kandagatla Cc: Greg Kroah-Hartman Cc: Bartosz Golaszewski Cc: Arnd Bergmann Signed-off-by: Bartosz Golaszewski Signed-off-by: Greg Kroah-Hartman --- drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -719,7 +719,7 @@ static int at24_probe(struct i2c_client nvmem_config.name = dev_name(dev); nvmem_config.dev = dev; nvmem_config.read_only = !writable; - nvmem_config.root_only = true; + nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO); nvmem_config.owner = THIS_MODULE; nvmem_config.compat = true; nvmem_config.base_dev = dev;