From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21EEDC32756 for ; Thu, 8 Aug 2019 19:16:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2FC521883 for ; Thu, 8 Aug 2019 19:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291769; bh=kE+APflZXVKBi88zg/ds609nqfZ49BLod9mXTr2oUYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yUeRvLoHYqrhq6BasQP8AUpZxjdXS6xJOqrMXEA2BgieN31G1in1l4wIdzzt3cZEK Ux6uBkc+K4c6csbSDqxd9JrFEBiMKSoDSZIm6kTXCkUTf/hsRQYqqu0wrUGq+ZXJSD FI4QLDlqda3HDlI8GKC4x7D+KzKAGruMUpPFuVAI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404206AbfHHTGG (ORCPT ); Thu, 8 Aug 2019 15:06:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:39366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404142AbfHHTGE (ORCPT ); Thu, 8 Aug 2019 15:06:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 947512173E; Thu, 8 Aug 2019 19:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565291164; bh=kE+APflZXVKBi88zg/ds609nqfZ49BLod9mXTr2oUYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FKKprx0ukGzBWvMkWCARUjZAxgDnHKa8hTHABVtoJY+seQF0qD9xt5GSnoY9HV47w ZfUgVHp/BFgG7VcoAWxzu97m6l1I+TfnHoBvEI6YN11kykZZU0z5A7GlqmYv7sUmpl NlSIXYhLuUfNa0XfBzJGpF4CN0ljwQZxmdVayCJM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+fbb5b288c9cb6a2eeac4@syzkaller.appspotmail.com, Jamal Hadi Salim , Jiri Pirko , Cong Wang , "David S. Miller" Subject: [PATCH 5.2 11/56] ife: error out when nla attributes are empty Date: Thu, 8 Aug 2019 21:04:37 +0200 Message-Id: <20190808190453.321356252@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190808190452.867062037@linuxfoundation.org> References: <20190808190452.867062037@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Cong Wang [ Upstream commit c8ec4632c6ac9cda0e8c3d51aa41eeab66585bd5 ] act_ife at least requires TCA_IFE_PARMS, so we have to bail out when there is no attribute passed in. Reported-by: syzbot+fbb5b288c9cb6a2eeac4@syzkaller.appspotmail.com Fixes: ef6980b6becb ("introduce IFE action") Cc: Jamal Hadi Salim Cc: Jiri Pirko Signed-off-by: Cong Wang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sched/act_ife.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/net/sched/act_ife.c +++ b/net/sched/act_ife.c @@ -481,6 +481,11 @@ static int tcf_ife_init(struct net *net, int ret = 0; int err; + if (!nla) { + NL_SET_ERR_MSG_MOD(extack, "IFE requires attributes to be passed"); + return -EINVAL; + } + err = nla_parse_nested_deprecated(tb, TCA_IFE_MAX, nla, ife_policy, NULL); if (err < 0)