From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B2A4C41514 for ; Wed, 14 Aug 2019 17:21:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E988820665 for ; Wed, 14 Aug 2019 17:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565803299; bh=hk+BW2g498HkjhgTTJ87szRPCj5bd3Unj3WwSKMmQNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=03oiFsn4Sy0k25Y8MARGhPjVHsfTKt9xAhL5dOQi2HBXoYiAziJ4820M0MBrj2/zY /tN1pC7CpHwoTLdjEndJMESSE1tYtRr/1eTUpl/rq0iwSJJaLbiyPtIJk5kEiFtC3z ULXipoxrC0J5pBXdM8K1uXrd7yLjZrp+zh+hmEs4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729625AbfHNRJm (ORCPT ); Wed, 14 Aug 2019 13:09:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:60174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729904AbfHNRJl (ORCPT ); Wed, 14 Aug 2019 13:09:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 76395208C2; Wed, 14 Aug 2019 17:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802580; bh=hk+BW2g498HkjhgTTJ87szRPCj5bd3Unj3WwSKMmQNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WIHElwq85bjTD7crVgekgmHBveEUoPLDxxiThVVvk0d5J1FITy8KNJtQ7SrQL18xM cmVksLNc4M9mlgWRyelwSfPCfHmblF/UpL95WE7ciSnWUNXssrd1g2e1BKga1zTOlm WYJWfnq/vMV32GL5xgXpgQ8VGJrtvF84hTfYPpH8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gary R Hook , Herbert Xu Subject: [PATCH 4.19 07/91] crypto: ccp - Ignore tag length when decrypting GCM ciphertext Date: Wed, 14 Aug 2019 19:00:30 +0200 Message-Id: <20190814165749.388040530@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165748.991235624@linuxfoundation.org> References: <20190814165748.991235624@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Gary R Hook commit e2664ecbb2f26225ac6646876f2899558ffb2604 upstream. AES GCM input buffers for decryption contain AAD+CTEXT+TAG. Only decrypt the ciphertext, and use the tag for comparison. Fixes: 36cf515b9bbe2 ("crypto: ccp - Enable support for AES GCM on v5 CCPs") Cc: Signed-off-by: Gary R Hook Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/ccp/ccp-ops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/crypto/ccp/ccp-ops.c +++ b/drivers/crypto/ccp/ccp-ops.c @@ -785,8 +785,7 @@ static int ccp_run_aes_gcm_cmd(struct cc while (src.sg_wa.bytes_left) { ccp_prepare_data(&src, &dst, &op, AES_BLOCK_SIZE, true); if (!src.sg_wa.bytes_left) { - unsigned int nbytes = aes->src_len - % AES_BLOCK_SIZE; + unsigned int nbytes = ilen % AES_BLOCK_SIZE; if (nbytes) { op.eom = 1;