From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org, Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH -stable v4.14] mm/usercopy: use memory range to be accessed for wraparound check
Date: Fri, 16 Aug 2019 20:41:13 +0200 [thread overview]
Message-ID: <20190816184113.GA26008@kroah.com> (raw)
In-Reply-To: <201908161123.93DFEB96@keescook>
On Fri, Aug 16, 2019 at 11:24:08AM -0700, Kees Cook wrote:
> From: Prasad Sodagudi <psodagud@codeaurora.org>
>
> commit 951531691c4bcaa59f56a316e018bc2ff1ddf855 upstream.
>
> Currently, when checking to see if accessing n bytes starting at address
> "ptr" will cause a wraparound in the memory addresses, the check in
> check_bogus_address() adds an extra byte, which is incorrect, as the
> range of addresses that will be accessed is [ptr, ptr + (n - 1)].
>
> This can lead to incorrectly detecting a wraparound in the memory
> address, when trying to read 4 KB from memory that is mapped to the the
> last possible page in the virtual address space, when in fact, accessing
> that range of memory would not cause a wraparound to occur.
>
> Use the memory range that will actually be accessed when considering if
> accessing a certain amount of bytes will cause the memory address to
> wrap around.
>
> Link: http://lkml.kernel.org/r/1564509253-23287-1-git-send-email-isaacm@codeaurora.org
> Fixes: f5509cc18daa ("mm: Hardened usercopy")
> Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> Co-developed-by: Prasad Sodagudi <psodagud@codeaurora.org>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> Acked-by: Kees Cook <keescook@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Trilok Soni <tsoni@codeaurora.org>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> [kees: backport to v4.14]
> Signed-off-by: Kees Cook <keescook@chromium.org>
This and the 4.9 patch now queued up, thanks for the backports.
greg k-h
prev parent reply other threads:[~2019-08-16 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 18:24 [PATCH -stable v4.14] mm/usercopy: use memory range to be accessed for wraparound check Kees Cook
2019-08-16 18:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816184113.GA26008@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=stable@vger.kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).