From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66EF3C3A589 for ; Tue, 20 Aug 2019 13:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 306872332A for ; Tue, 20 Aug 2019 13:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566308579; bh=8EC/IqFK7cYJWrqHFTdbNdl1R6ctwn0PAOTv1t8eTZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=c8wx7N708YYZKTi2Ipi0suH67G08QU4GD8xP6fkgSDZfFZEXUmcyiuZTUR56ACZyf HEoQ6+fcrMzbiZQmnAcZ5If4wzCtzZfNmDjYf441Evfda0WMkZ0BWqPqXF95fKgixg Sy4ZZB2HfskIOGBpo2mS/FSoj05Ev2enf1s62KXs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730748AbfHTNm6 (ORCPT ); Tue, 20 Aug 2019 09:42:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:38444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730745AbfHTNm6 (ORCPT ); Tue, 20 Aug 2019 09:42:58 -0400 Received: from sasha-vm.mshome.net (unknown [12.236.144.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 153D722DBF; Tue, 20 Aug 2019 13:42:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566308577; bh=8EC/IqFK7cYJWrqHFTdbNdl1R6ctwn0PAOTv1t8eTZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QZqVExN1SWxCHm0Arj/6mYLbLf5Pv5KcURCbfi8A07TF4xJFXcEzFjcQJH41vlyI0 iSOy5KfXTqHouzedFaagySEvrCKiJZIrXKIlkfz2oW8HPGgcG91qhJsVCMb31bCWLc 0xQs+Joy7o9T6PR3Dbz71jG2yNq3dcNdAaMT6z6c= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jacopo Mondi , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin , linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 02/12] iio: adc: max9611: Fix temperature reading in probe Date: Tue, 20 Aug 2019 09:42:43 -0400 Message-Id: <20190820134253.11562-2-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190820134253.11562-1-sashal@kernel.org> References: <20190820134253.11562-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jacopo Mondi [ Upstream commit b9ddd5091160793ee9fac10da765cf3f53d2aaf0 ] The max9611 driver reads the die temperature at probe time to validate the communication channel. Use the actual read value to perform the test instead of the read function return value, which was mistakenly used so far. The temperature reading test was only successful because the 0 return value is in the range of supported temperatures. Fixes: 69780a3bbc0b ("iio: adc: Add Maxim max9611 ADC driver") Signed-off-by: Jacopo Mondi Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/max9611.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c index f8f298c33b287..c61fbf5602718 100644 --- a/drivers/iio/adc/max9611.c +++ b/drivers/iio/adc/max9611.c @@ -484,7 +484,7 @@ static int max9611_init(struct max9611_dev *max9611) if (ret) return ret; - regval = ret & MAX9611_TEMP_MASK; + regval &= MAX9611_TEMP_MASK; if ((regval > MAX9611_TEMP_MAX_POS && regval < MAX9611_TEMP_MIN_NEG) || -- 2.20.1