From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF68CC3A5A1 for ; Thu, 22 Aug 2019 17:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95F6A233FC for ; Thu, 22 Aug 2019 17:36:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566495375; bh=l1Veyl/6ndYeQWcC5Y3ELTibSQReR/t8QEJFI+yoMco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CNcWthdBAyYZm6fKQ99ghp9N61CCh9EwoKUw4FcCDU4hlLzXEgGivdtbUqnqSsKjo vHoGQsYv9QBwZo5HzrA9GFtW0+wpz9jN/QO533WVuJsUJ70Wij8ED5paw6aLvVXcAH aYh9MH9LJyD+xZYfIXCFULyL1lWYIPbLGS8HKK0w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391131AbfHVRgL (ORCPT ); Thu, 22 Aug 2019 13:36:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387840AbfHVRY4 (ORCPT ); Thu, 22 Aug 2019 13:24:56 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B3DF2341B; Thu, 22 Aug 2019 17:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494695; bh=l1Veyl/6ndYeQWcC5Y3ELTibSQReR/t8QEJFI+yoMco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mkIm/WckC1RzqJlpF8HgqYmz+fqgNnn1ekdfNrOs4dJxnRYPL/3+KEN08A1hTQAsg yzz79Ze4l5sr07TaW0rAhInUMXINGCzqMJVeeI0sakAf6g3JLEUX4YiONmO8PSNIEy t4XsoPjUWqnUJ5eKpjY036vWjj+Sh0jfm8HEAuNc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , Takashi Iwai Subject: [PATCH 4.14 11/71] ALSA: hda - Fix a memory leak bug Date: Thu, 22 Aug 2019 10:18:46 -0700 Message-Id: <20190822171727.459974672@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171726.131957995@linuxfoundation.org> References: <20190822171726.131957995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wenwen Wang commit cfef67f016e4c00a2f423256fc678a6967a9fc09 upstream. In snd_hda_parse_generic_codec(), 'spec' is allocated through kzalloc(). Then, the pin widgets in 'codec' are parsed. However, if the parsing process fails, 'spec' is not deallocated, leading to a memory leak. To fix the above issue, free 'spec' before returning the error. Fixes: 352f7f914ebb ("ALSA: hda - Merge Realtek parser code to generic parser") Signed-off-by: Wenwen Wang Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -5945,7 +5945,7 @@ static int snd_hda_parse_generic_codec(s err = snd_hda_parse_pin_defcfg(codec, &spec->autocfg, NULL, 0); if (err < 0) - return err; + goto error; err = snd_hda_gen_parse_auto_config(codec, &spec->autocfg); if (err < 0)