From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C0CC3A5A1 for ; Thu, 22 Aug 2019 17:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4047A20856 for ; Thu, 22 Aug 2019 17:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566495815; bh=Qxmb6vn3g3QEs2Y31wCulIpv1Hya/mij5H+crVxaM88=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NseQ0djE741AIgobADZF5QFENopC74JCxz2F6zBEmlRDzlbJOkZemVdByk2gyXa9N GQr+gRh2pgUq1FTg0Oy16uYftoOs9ubHAe41C2u21M7UTBZ3pYP7NHvwufDk29Mnu4 4Km/gCv2Y6+jafkCBv0DqMAKM7etNTlv9XdUj10w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405261AbfHVRnW (ORCPT ); Thu, 22 Aug 2019 13:43:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:43432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389984AbfHVRX2 (ORCPT ); Thu, 22 Aug 2019 13:23:28 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EC7423406; Thu, 22 Aug 2019 17:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494608; bh=Qxmb6vn3g3QEs2Y31wCulIpv1Hya/mij5H+crVxaM88=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=foxWwP141Q1oLMK0E8OlBHm6txcg6gImsw7fQehg3SJienL+OiTJP0T4xGehiVQyH e/3YpaBU5vnYri3RKZ7GW7qEQW0jXqLjH19NdO+YGLuw95zG0fxwgxef8Sci0Hntyn UoMXyMWhc4nAe0+vlRZFFoaSUpBYohjkUky8XiGg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomas Bortoli , syzbot+d6a5a1a3657b596ef132@syzkaller.appspotmail.com, Marc Kleine-Budde Subject: [PATCH 4.9 031/103] can: peak_usb: pcan_usb_pro: Fix info-leaks to USB devices Date: Thu, 22 Aug 2019 10:18:19 -0700 Message-Id: <20190822171730.094161937@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171728.445189830@linuxfoundation.org> References: <20190822171728.445189830@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tomas Bortoli commit ead16e53c2f0ed946d82d4037c630e2f60f4ab69 upstream. Uninitialized Kernel memory can leak to USB devices. Fix by using kzalloc() instead of kmalloc() on the affected buffers. Signed-off-by: Tomas Bortoli Reported-by: syzbot+d6a5a1a3657b596ef132@syzkaller.appspotmail.com Fixes: f14e22435a27 ("net: can: peak_usb: Do not do dma on the stack") Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/can/usb/peak_usb/pcan_usb_pro.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_pro.c @@ -500,7 +500,7 @@ static int pcan_usb_pro_drv_loaded(struc u8 *buffer; int err; - buffer = kmalloc(PCAN_USBPRO_FCT_DRVLD_REQ_LEN, GFP_KERNEL); + buffer = kzalloc(PCAN_USBPRO_FCT_DRVLD_REQ_LEN, GFP_KERNEL); if (!buffer) return -ENOMEM;