From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 487A2C3A5A6 for ; Tue, 27 Aug 2019 08:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D9B6206BA for ; Tue, 27 Aug 2019 08:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566893646; bh=I2smVJliUFII8oEaC9GY5BqS7YV28ykYbm5vJwOO2Xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TOxeMblD3RsHZqFD0uhh0nT7A1yH520clteNxg/oNX6PhyHjq33BX2JbkaVP6x+GL Zsc6Sw2E6/4bLa0Ca5sMVR281RCZUMxN+7+hAm6POBWaDN3OIelH11/AVdlCg/sHrA HbM69YQwkEurPFoCEUSPBzY6pzwj7C8JjG5gvE5k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730215AbfH0H5C (ORCPT ); Tue, 27 Aug 2019 03:57:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:49196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730731AbfH0H5C (ORCPT ); Tue, 27 Aug 2019 03:57:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B989206BA; Tue, 27 Aug 2019 07:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892621; bh=I2smVJliUFII8oEaC9GY5BqS7YV28ykYbm5vJwOO2Xw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mbEFoNq1qt0oA0gXXWELfWdvKIYODchcB3BXd4q/9b+g+dlCZXWRxTHSCnDt3mRoC 8kxayvOrT9mrprEJfGIurGn4EeH9mdnTT6Zl31/u8Jvh5JB9+k+3MTO4ZgddWiZaHX gTVep+8qQ+GenoYqBKWlpJ6//mlhdkFaV+WmAOU8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 16/98] st_nci_hci_connectivity_event_received: null check the allocation Date: Tue, 27 Aug 2019 09:49:55 +0200 Message-Id: <20190827072719.170733598@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072718.142728620@linuxfoundation.org> References: <20190827072718.142728620@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 3008e06fdf0973770370f97d5f1fba3701d8281d ] devm_kzalloc may fail and return NULL. So the null check is needed. Signed-off-by: Navid Emamdoost Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/nfc/st-nci/se.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c index f55d082ace715..5d6e7e931bc6c 100644 --- a/drivers/nfc/st-nci/se.c +++ b/drivers/nfc/st-nci/se.c @@ -344,6 +344,8 @@ static int st_nci_hci_connectivity_event_received(struct nci_dev *ndev, transaction = (struct nfc_evt_transaction *)devm_kzalloc(dev, skb->len - 2, GFP_KERNEL); + if (!transaction) + return -ENOMEM; transaction->aid_len = skb->data[1]; memcpy(transaction->aid, &skb->data[2], transaction->aid_len); -- 2.20.1